Closed Bug 1126124 Opened 9 years ago Closed 9 years ago

Stop defining non-configurable properties on windows in Gaia

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set
normal

Tracking

(b2g-master fixed)

RESOLVED FIXED
2.2 S5 (6feb)
Tracking Status
b2g-master --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

      No description provided.
Blocks: 1107443
Attached file Fix
Attachment #8554990 - Flags: review?(rlu)
Attachment #8554990 - Flags: review?(arthur.chen)
Comment on attachment 8554990 [details]
Fix

Please also make the title of the PR same as the commit message, thanks.
Attachment #8554990 - Flags: review?(arthur.chen) → review+
Comment on attachment 8554990 [details]
Fix

Hi bz,

Looks good to me, but please help fix the lint error as I commented on github pull request.
Thank you very much.
Attachment #8554990 - Flags: review?(rlu) → review+
Keywords: checkin-needed
Master: https://github.com/mozilla-b2g/gaia/commit/aaba386e14bbacd4ba4ff3aa9a1611f306d1fa07

Note that this still needs to merge from b2g-inbound to m-c (and back around to inbound) before bug 1107443 can re-land.
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S5 (6feb)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: