1126137 - Add Treeherder support for new job name dolphin-512

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Data Ingestion, defect, P1)

Comment 1

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: Add dolphin-512 to treeherder-service.

Ed, could you review this? Thanks!

Comment 2

[Ryan VanderMeulen [:RyanVM]]

To add more context, these were already enabled in production and are getting munged at the moment.

b2g_mozilla-b2g34_v2_1s_dolphin-512_periodic is showing up as a Dolphin(B) job.
b2g_mozilla-b2g34_v2_1s_dolphin-512_eng_periodic is showing up as an Unknown(Be) job.

I'm wondering if we could stand to loosen up the Dolphin regex a bit too so that the Be job would at least get matched into the Dolphin group by default. Would be slightly better UX.

Comment 3

[Ed Morley [:emorley]]

Comment on attachment 8555014 [details] [review]
Add dolphin-512 to treeherder-service.

Thank you for the patch! :-)

Could you add some tests? (Doesn't need to be for every permutation, just some)
eg: https://github.com/mozilla/treeherder-service/commit/539a5ef807c2cffc0c0b2ca95ccceceffa06145f

(There are some changes being tested on stage, blocked on bug 1126226, so this can't land immediately anyway)

Comment 4

[Kai-Zhen Li [:seinlin][:kli]]

Ed, Thanks! But I have no idea on how to add unit test for Firefox OS device build. Do you have an instruction guide of an example of adding unit test for Firefox OS device build?

Comment 5

[Ed Morley [:emorley]]

See the link to the example new test in comment 3 :-)

Comment 6

[Kai-Zhen Li [:seinlin][:kli]]

Comment on attachment 8555014 [details] [review]
Add dolphin-512 to treeherder-service.

Ed, I updated to PR. Could you have a look? Thanks!

Comment 7

[Ed Morley [:emorley]]

Comment on attachment 8555014 [details] [review]
Add dolphin-512 to treeherder-service.

Thank you for the tests :-)
They've highlighted an issue with false positives - have left a comment on the PR. Almost there!

Comment 8

[Kai-Zhen Li [:seinlin][:kli]]

Comment on attachment 8555014 [details] [review]
Add dolphin-512 to treeherder-service.

Ed, I updated PR and now test result is green. Could you have a look? Thanks!

Comment 9

[Ed Morley [:emorley]]

Comment on attachment 8555014 [details] [review]
Add dolphin-512 to treeherder-service.

That looks great - thank you :-)

Comment 10

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/a4e4c789911694e577ffd34fbf8a001a919bb8f2
Bug 1126137 - Add dolphin-512 to treeherder-service.

https://github.com/mozilla/treeherder-service/commit/20dbcf8545901fd7fa59ee0feb4958888e28fbde
Merge pull request #353 from Seinlin/bug-1126137

Bug 1126137 - Add dolphin-512 to treeherder-service.

Comment 11

[Ed Morley [:emorley]]

This should get deployed in the next few days, once some testing of other changes is complete on stage :-)

Comment 12

[Kai-Zhen Li [:seinlin][:kli]]

Ed, Thanks!