1126138 - Bug 1120161 broke about:support#sandbox (Linux only) with 'use strict' violations

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

The implementation of about:support#sandbox, which is ifdef'ed for Linux only, has an implicitly declared for-of loop variable, which broke when bug 1120161 added a "use strict".  The fix is trivial.

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: bug1126138-let-key-of-keys-hg0.diff

Comment 2

[Chris Peterson [:cpeterson]]

[Tracking Requested - why for this release]:

We should probably uplift this fix to Aurora 37. Without this fix, the about:support page will fail to load on Linux.

Comment 3

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

(In reply to Chris Peterson [:cpeterson] from comment #2)
> [Tracking Requested - why for this release]:
> 
> We should probably uplift this fix to Aurora 37. Without this fix, the
> about:support page will fail to load on Linux.

For what it's worth: it looks as if the rest of the page loads normally, and the ReferenceError in the browser console is styled as a warning rather than an error.  But I think this should be uplifted regardless, because it definitely does break the sandbox section.

Comment 4

[Lawrence Mandel [:lmandel] (use needinfo)]

Given that the page does load (comment 3) and this is more a matter of styling or restricted to a single section of the page, I don't think is significant enough to track. I'm happy to approve a trivial fix for uplift.

Comment 5

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b084792f0e9

Comment 6

[Drew Willcoxon :adw]

Comment on attachment 8555016 [details] [diff] [review]
bug1126138-let-key-of-keys-hg0.diff

Review of attachment 8555016 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 7

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

checkin-needed; try link in comment #5.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3ac7afad5449

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3ac7afad5449