Closed
Bug 1126139
Opened 10 years ago
Closed 10 years ago
Add an android:label for the reading list provider
Categories
(Firefox for Android Graveyard :: Data Providers, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 38
People
(Reporter: rnewman, Assigned: rnewman)
References
Details
Attachments
(1 file)
|
1.45 KB,
patch
|
nalexander
:
review+
|
Details | Diff | Splinter Review |
This is necessary for it to show a meaningful checkbox in Android's account settings.
|
Assignee | |
Comment 1•10 years ago
|
||
Pretty trivial, but wanted to make sure this wasn't only in my head.
This shows "Reading List" in the account settings.
Attachment #8555009 -
Flags: review?(nalexander)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8555009 [details] [diff] [review]
Add an android:label for the reading list provider. v1
Review of attachment 8555009 [details] [diff] [review]:
-----------------------------------------------------------------
::: mobile/android/base/AndroidManifest.xml.in
@@ +427,5 @@
> android:permission="@ANDROID_PACKAGE_NAME@.permissions.BROWSER_PROVIDER"/>
>
> <provider android:name="org.mozilla.gecko.db.ReadingListProvider"
> android:authorities="@ANDROID_PACKAGE_NAME@.db.readinglist"
> + android:label="@string/reading_list_title"
Let's make this android:exported="false" while we're here.
Attachment #8555009 -
Flags: review?(nalexander) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•