1126156 - [Camera][dolphin][FFOS7715 v2.1] [performance] back camera switch to front camera, ffos2.1 7715ea is slower than ffos1.4 7715ga about 35.81%.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[jinchao.wang]

*** Build Information ***
Device-Name     dolphin 7715ea

*** Description ***
back camera switch to front camera, ffos2.1 7715ea is slower than ffos1.4 7715ga about 35.81%.

*** Steps to Reproduce ***
1.open camera
2.click button to switch camera

*** Expected Results ***
ffos2.1 7715ea is similar with ffos1.4 7715ga， and narrow the gap to less than 10%.

*** Actual Results ***
ffos2.1 7715ea is slower than ffos1.4 7715ga about 35.81%.

*** The average time ***
DUT,Dophin 7715ea ffos2.1 ：  1.797s/1.812s/1.832s   average：1.814s
Flame FFOS_V2.1：             3.032s/2.67s/2.890s    average：2.865s
7715 Android4.4:              0.896s/1.07s/0.897s    average：0.954s
7715 FFOS_V1.4:               1.52s/1.27s/1.21s      average：1.335s

Comment 1

[jinchao.wang]

resolved

Comment 2

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

Hi Jinchao -

Could you share with us how you improve the performance and fix this bug?

Thanks!

Comment 3

[jinchao.wang]

Hi Vance：
    
camera/js/controllers/viewfinder.js：
  this.camera.on('preview:started', this.show);
  >> 
  ViewfinderController.prototype.show = function() {
    if (!this.app.criticalPathDone) {
      this.views.viewfinder.fadeIn(1);
      return;
    }
    // for mozilla bug 982230， we add this delay
    // I change 280ms to 100ms
    // ffos 1.4 didn't has the delay time.
    clearTimeout(this.showTimeout);
    this.showTimeout = setTimeout(this.views.viewfinder.fadeIn, 280);
  };

camera/js/views/viewfinder.js：
  fadeIn: function(ms, done) {

    // fadeTime default value is 360 ms
    // ffos 1.4 didn't has the transition
    ms = ms || this.fadeTime;
    // this.el.style.transitionDuration = ms + 'ms';

    this.show();
    clearTimeout(this.fadeTimeout);
    this.fadeTimeout = setTimeout(function() {
      document.body.classList.add('no-background');
      self.el.style.transitionDuration = '';
      self.emit('fadedin');
      if (done) { done(); }
    }, ms);
  },