1126218 - Simplify SourceActor.prototype._createBreakpoint

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Eddy Bruel [:ejpbruel]]

SourceActor.prototype._createBreakpoint can be simplified significantly. Note that I eventually want to get rid of this function completely. All it does is convert the actual location returned by setBreakpoint (which is a generated location) to an original location.

Since setBreakpoint is going to slide on original lines, it should return an actual location that is an original location as well. The plan is to initially move the conversion logic in _createBreakpoint to setBreakpoint, and then to get rid of it completely once we've implemented breakpoint sliding on original lines.

In any case, simplifying the logic for createBreakpoint will make it easier for me to integrate it with setBreakpoint in a future patch.

Comment 1

[Eddy Bruel [:ejpbruel]]

Attachment: patch

Comment 2

[Eddy Bruel [:ejpbruel]]

Try push for this patch:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e656a043eede

Comment 3

[Eddy Bruel [:ejpbruel]]

New try push because the patch on top of which this one is based had some errors:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1fd2aeb66f03

Comment 4

[Eddy Bruel [:ejpbruel]]

Try run looks green, pushing to fx-team:
https://hg.mozilla.org/integration/fx-team/rev/c5f5390dc422

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c5f5390dc422