Closed Bug 1126234 Opened 9 years ago Closed 9 years ago

[Loop] Sound is heard through the speaker when opening loop app

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: isabelrios, Assigned: jaoo)

Details

(Whiteboard: [Room1.1.1_TestRun2][loop approved for 1.1.1][In 1.1.1])

Attachments

(1 file)

Fire E 2.0
Loop 1.1.1/d4d6d37
Pre-requisites
User A with headset connected

STR
-User A has created and shared a room with user B, user A is in the room (although it is reproducible also when user A is not in the room)
-User B joins the room and user A receives the notification 
-User A taps on the notification

ACTUAL
When user A taps on the notification, he is taken to the room, and the radio starts listening through the speaker

EXPECTED
Radio should not be played through the speaker without user interaction. Sound should be played through headset.
Status: NEW → ASSIGNED
Comment on attachment 8555299 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/518

Hey Cristian, let's pair up for this review if needed. Thanks!
Attachment #8555299 - Flags: review?(crdlc)
Comment on attachment 8555299 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/518

Bug 1126234 have some relationship with this bug. Part of the patch being proposed here fits better with the issue in that bug. I'll cancel the review request until I refactor the patch here. Sorry for the noise.
Attachment #8555299 - Flags: review?(crdlc)
Attachment #8555299 - Flags: review?(borja.bugzilla)
Attachment #8555299 - Flags: review?(borja.bugzilla) → review+
Landed on master branch at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/b0fd16cfa2191e387612acd12e6c6269c3e1c563
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [Room1.1.1_TestRun2] → [Room1.1.1_TestRun2][Not in 1.1.1]
I have tested this bug on latest master and it is working fine now. Although, I am afraid I have seen another bug, will check it offline and file it in case is needed.

Thanks!
Steps followed to see the bug I was referring to in previous comment 5:
-Once the call between A (with headset) and B is ongoing, unplug the headset.
-The sound in A is not heard through the speaker although the button is active.
I'm having a look at it. I'll file a new bug or fix this as a follow-up patch of the one landed here. Thanks Isabel.
Bug 1128524 was filed to handle the issue reported by Isabel in comment 5, this issue was happening before landing this patch.

Low risk patch confirmed by Jose Antonio, already tested by Isabel, let's uplift it to 1.1.1 branch.
Thanks a lot!!
Flags: needinfo?(josea.olivera)
Whiteboard: [Room1.1.1_TestRun2][Not in 1.1.1] → [Room1.1.1_TestRun2][Not in 1.1.1][loop approved for 1.1.1]
Landed in 1.1.1 branch at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/2f66394f2c1e3e4ab6742d14603708c9c5241c72
Flags: needinfo?(josea.olivera)
Whiteboard: [Room1.1.1_TestRun2][Not in 1.1.1][loop approved for 1.1.1] → [Room1.1.1_TestRun2][loop approved for 1.1.1][In 1.1.1]
Tested, now Radio should not be played through the speaker without user interaction
Verified on Fire E 2.0
Loop 1.1.1/ 39a5284
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: