1126235 - Facebook friends' names are not removed if you clear the string and tap Update

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Shally Li（leave from Mozilla）]

[1.Description]:
According to Bug 1006521 in Comment 10, this bug is filed.
[Flame][v2.0&2.1&2.2][Contacts]The FB conact’s first name (or last name) can‘t be updated successfully after user remove the first name (or Last name) of Facebook contact and then tap Update, and it still displays its original name.
Attch:logcat_1343.txt and fb_contact.MP4.
Found time:13:43

[2.Testing Steps]: 
1.Import Facebook contacts.
2.Open a FB contact.
3.Tap Edit.
4.Tap "X" icon  in "Name" (or "Last name") field.
5.Tap Update.
6.Tap < icon to back to contact list.

[3.Expected Result]: 
5&6.Can remove the first name or last name and update successfully.

[4.Actual Result]: 
5&6.The original first name and original last name still displays in contact detail page and contact list.

[5.Reproduction build]: 
Flame v2.0 build:
Gaia-Rev        2989f2b2bd12fcc0e9c017d2db766e76a55873b8
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/b4c61fd1dcfc
Build-ID        20150126000204
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150126.033406
FW-Date         Mon Jan 26 03:34:17 EST 2015
Bootloader      L1TC000118D0

Flame v2.1 build:
Gaia-Rev        2989f2b2bd12fcc0e9c017d2db766e76a55873b8
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/b4c61fd1dcfc
Build-ID        20150126000204
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150126.033406
FW-Date         Mon Jan 26 03:34:17 EST 2015
Bootloader      L1TC000118D0

Flame v2.2 buid:
Gaia-Rev        0518f4581a0925c0b703d730ef289ab15cbd1216
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c6aa604a7967
Build-ID        20150126002536
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150126.042138
FW-Date         Mon Jan 26 04:21:49 EST 2015
Bootloader      L1TC000118D0


[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[Shally Li（leave from Mozilla）]

Attachment: logcat_1343.txt

Comment 2

[Shally Li（leave from Mozilla）]

Attachment: fb_contact.MP4

Comment 3

[Noemí Freire (:noemi)]

The same behavior occurs on today's (1/27) master build. Environmental variables:
Flame 3.0 device
Gecko: ab1e320
Gaia: 5dd0226
BuildId: 20150127081554
Platform version: 38.0a1

Comment 4

[Jose Manuel Cantera]

This bug should be closed as invalid as the app is working as expected. Let me explain here in detail how it should and is actually working:

A contact imported from Facebook can be edited. That means that you can change the FB photo by a local one or change the name or other values. The rule is that local data takes precedence over remote data. Once a FB Contact is edited it promotes to the 'linked' state. 

Imagine you have a FB Contact, you edit the contact, change to a new local name. In that case the new local name appears. Then, edit the contact one more time, and remove the name. In that case the new local name is empty and as a result the new contact's name (which is actually a linked contact) will be the FB one. 

So, if you have a just imported FB Contact, then remove the name and save, the result would be as it you had not been done anything, because in that case the new linked contact name will be the FB name, as the local one is empty. 

So the behavior is correct and there is no a bug, for all the reasons explained above. 

Please let me know if you need further clarifications and if you agree, you can close the bug.

thanks

Comment 5

[Shally Li（leave from Mozilla）]

Per comment 4,close this bug.(In reply to Jose Manuel Cantera from comment #4)
> Please let me know if you need further clarifications and if you agree, you
> can close the bug.

Hi Jose,

    I can modify this first name or last name of FB contact,such as "Feego Chen" -> "Feego Ailsa", but can't remove the first name or last name.

Thanks.

Comment 6

[Johan Lorenzo [:jlorenzo]]

Just wondering if we could warn the user about this rule. For instance, when you clear a field from a Facebook friend, a confirmation window will show and say something like: "As you cleared this field, the Facebook data will be restored"

I think UX input would be valuable here. What do think Carrie?

Comment 7

[Jose Manuel Cantera]

(In reply to Shally from comment #5)
> Per comment 4,close this bug.(In reply to Jose Manuel Cantera from comment
> #4)
> > Please let me know if you need further clarifications and if you agree, you
> > can close the bug.
> 
> Hi Jose,
> 
>     I can modify this first name or last name of FB contact,such as "Feego
> Chen" -> "Feego Ailsa", but can't remove the first name or last name.
> 
> Thanks.

You can remove it by clicking on the 'x' over the field. However, when you save the name will remain as I explained on comment #4. 

thanks

Comment 8

[Jose Manuel Cantera]

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #6)
> Just wondering if we could warn the user about this rule. For instance, when
> you clear a field from a Facebook friend, a confirmation window will show
> and say something like: "As you cleared this field, the Facebook data will
> be restored"

That could be too much, as anytime a Facebook field takes precedence we would need to inform the user

> 
> I think UX input would be valuable here. What do think Carrie?

Comment 9

[Carrie Wang [New account: [e-mail]]]

I think popping up a confirm window is really too much and even with that description, users will get more confused. Can we just not replace the removed name with the FB name? If users delete the name, it should be deleted. Thanks!

Comment 10

[Jose Manuel Cantera]

(In reply to Carrie Wang [:carrie] from comment #9)
> I think popping up a confirm window is really too much and even with that
> description, users will get more confused. Can we just not replace the
> removed name with the FB name? If users delete the name, it should be
> deleted. Thanks!

If we did that we would be changing the logic of how the Facebook link functionality works and all the FB integration.

Comment 11

[Johan Lorenzo [:jlorenzo]]

Facebook was removed in bug 1178891.