Removal of the unload event handler in browser-data-submission-info-bar.js is broken and can go away

RESOLVED FIXED in Firefox 38

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: dao, Assigned: alexxdim94, Mentored)

Tracking

Trunk
Firefox 38
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][lang=js])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
The removal of the unload event handler in gDataNotificationInfoBar.init (see browser/base/content/browser-data-submission-info-bar.js) is broken, because the function added as the event listener is different from the function passed to removeEventListener ('function onUnload() {...}.bind(this)' vs. 'unUnload'). We can just remove the broken removeEventListener call, because it's not needed.
(Reporter)

Updated

4 years ago
OS: Linux → All
Hardware: x86_64 → All
(Assignee)

Comment 1

4 years ago
Created attachment 8555226 [details] [diff] [review]
bug-1126259-fix.diff
Attachment #8555226 - Flags: review?(dao)
(Assignee)

Comment 2

4 years ago
Created attachment 8555228 [details] [diff] [review]
bug-1126259-fix.diff

Sorry, there was an unneeded empty line, removed it now.
Attachment #8555226 - Attachment is obsolete: true
Attachment #8555226 - Flags: review?(dao)
Attachment #8555228 - Flags: review?(dao)
(Reporter)

Comment 3

4 years ago
Comment on attachment 8555228 [details] [diff] [review]
bug-1126259-fix.diff

yes, thanks for taking care of the empty line too :)
Attachment #8555228 - Flags: review?(dao) → review+
(Reporter)

Updated

4 years ago
Assignee: nobody → alexxander.dimitrov
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b502cae6cf9b
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
You need to log in before you can comment on or make changes to this bug.