Closed
Bug 1126259
Opened 9 years ago
Closed 9 years ago
Removal of the unload event handler in browser-data-submission-info-bar.js is broken and can go away
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 38
People
(Reporter: dao, Assigned: alexxdim94, Mentored)
Details
(Whiteboard: [good first bug][lang=js])
Attachments
(1 file, 1 obsolete file)
1.02 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
The removal of the unload event handler in gDataNotificationInfoBar.init (see browser/base/content/browser-data-submission-info-bar.js) is broken, because the function added as the event listener is different from the function passed to removeEventListener ('function onUnload() {...}.bind(this)' vs. 'unUnload'). We can just remove the broken removeEventListener call, because it's not needed.
Reporter | ||
Updated•9 years ago
|
OS: Linux → All
Hardware: x86_64 → All
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8555226 -
Flags: review?(dao)
Assignee | ||
Comment 2•9 years ago
|
||
Sorry, there was an unneeded empty line, removed it now.
Attachment #8555226 -
Attachment is obsolete: true
Attachment #8555226 -
Flags: review?(dao)
Attachment #8555228 -
Flags: review?(dao)
Reporter | ||
Comment 3•9 years ago
|
||
Comment on attachment 8555228 [details] [diff] [review] bug-1126259-fix.diff yes, thanks for taking care of the empty line too :)
Attachment #8555228 -
Flags: review?(dao) → review+
Reporter | ||
Updated•9 years ago
|
Assignee: nobody → alexxander.dimitrov
Keywords: checkin-needed
Reporter | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/b502cae6cf9b
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b502cae6cf9b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
You need to log in
before you can comment on or make changes to this bug.
Description
•