If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[Loop] Play ended tone when leaving a Room from Firefox Hello application for every user that leaves a Room

VERIFIED FIXED

Status

Firefox OS
Gaia::Loop
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: jaoo, Assigned: jaoo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Room1.1.1_TestRun2][loop approved for 1.1.1][In 1.1.1])

Attachments

(1 attachment)

This is follow-up or regression (whatever) of bug 1124707. We play the 'connected' tone instead the 'ended' one. This was a nice mistake.
(Assignee)

Updated

3 years ago
Assignee: nobody → josea.olivera
Whiteboard: [Room1.1.1_TestRun2]
(Assignee)

Comment 1

3 years ago
Created attachment 8555304 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/519
Attachment #8555304 - Flags: review?(borja.bugzilla)
Attachment #8555304 - Flags: review?(borja.bugzilla) → review+
(Assignee)

Comment 2

3 years ago
Landed on master branch at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/fc9b8ce67d0395910b0ff993346a41597faaabf5
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Whiteboard: [Room1.1.1_TestRun2] → [Room1.1.1_TestRun2][Not in 1.1.1]
Very simple patch, no risky.
Jose Antonio, could you be so kind of uplifting it to 1.1.1 branch? Thanks a lot!
Flags: needinfo?(josea.olivera)
Whiteboard: [Room1.1.1_TestRun2][Not in 1.1.1] → [Room1.1.1_TestRun2][Not in 1.1.1][loop approved for 1.1.1]
(Assignee)

Comment 4

3 years ago
Landed on 1.1.1 branch at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/c9da92a3cef552ff9252269b74ae2bd22f704cec

Maria, could you please update the whiteboard if needed please? Thanks!
Flags: needinfo?(josea.olivera)
Whiteboard: [Room1.1.1_TestRun2][Not in 1.1.1][loop approved for 1.1.1] → [Room1.1.1_TestRun2][loop approved for 1.1.1][In loop 1.1.1]
It's pefect! thanks a lot!
Whiteboard: [Room1.1.1_TestRun2][loop approved for 1.1.1][In loop 1.1.1] → [Room1.1.1_TestRun2][loop approved for 1.1.1][In 1.1.1]
Tested and now when an invited/owner user leaves the room, a sound is listened.
Fire E 2.0
Loop 1.1.1/39a5284
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.