Closed
Bug 1126409
Opened 9 years ago
Closed 9 years ago
jit-test/tests/ion/simd-bug1121299.js is going to permafail when Gecko 38 merges to Aurora
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
VERIFIED
FIXED
mozilla38
People
(Reporter: RyanVM, Assigned: bbouvier)
Details
(Whiteboard: )
Attachments
(1 file)
1.28 KB,
patch
|
h4writer
:
review+
|
Details | Diff | Splinter Review |
[Tracking Requested - why for this release]: Permafail when Gecko 38 is uplifted to Aurora. https://treeherder.mozilla.org/logviewer.html#?job_id=4499401&repo=try TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/ion/simd-bug1121299.js | /builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jit-test/tests/ion/simd-bug1121299.js:7:6 ReferenceError: SIMD is not defined (code 3, args "--baseline-eager --no-fpu")
Flags: needinfo?(nicolas.b.pierron)
Comment 1•9 years ago
|
||
This needs a check like the on added in bug 1115217.
Assignee | ||
Comment 2•9 years ago
|
||
nbp is on PTO today, and it's an easy change. I've also moved the tests into the jit-tests/tests/SIMD dir, which was already existing somehow.
Attachment #8555754 -
Flags: review?(hv1989)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → benj
Status: NEW → ASSIGNED
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(nicolas.b.pierron)
Comment 3•9 years ago
|
||
Comment on attachment 8555754 [details] [diff] [review] Add SIMD check in test + move SIMD tests into jit-tests/tests/SIMD Review of attachment 8555754 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jit-test/tests/SIMD/bug1121299.js @@ +1,2 @@ > +if (!this.hasOwnProperty("SIMD")) > + quit(); Why not: typeof SIMD === undefined which is how we normally test this?
Attachment #8555754 -
Flags: review?(hv1989) → review+
Comment 4•9 years ago
|
||
s/undefined/"undefined"
Assignee | ||
Comment 5•9 years ago
|
||
As discussed on IRC, this semantically doesn't make a difference, so I let it like this. https://hg.mozilla.org/integration/mozilla-inbound/rev/c4df6e6c0321
Whiteboard:
Reporter | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c4df6e6c0321
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Reporter | ||
Comment 7•9 years ago
|
||
Looks great, thanks :)
Status: RESOLVED → VERIFIED
status-firefox38:
--- → verified
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•