Closed Bug 1126412 Opened 10 years ago Closed 8 years ago

Undefined KumaScript error caused by new rate limiting code

Categories

(developer.mozilla.org Graveyard :: KumaScript, defect)

Product:
developer.mozilla.org Graveyard
Component:
KumaScript
Platform:
All
Other
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Jeremie, Assigned: groovecoder)

Details

(Whiteboard: [specification][type:bug])

What did you do? ================ 1. Go to https://developer.mozilla.org/en-US/Learn/CSS/CSS_properties 2. There is a KumaScript error with the wording "Problem fetching source document: undefined" What happened? ============== The error happen after a round of editing, there is no obvious error in the source code. If there is a legitimate error, it's impossible to know which. What should have happened? ========================== No error or Error with an understandable message Is there anything else we should know? ======================================
Component: General → KumaScript
Bumping to critical. Happens to most/all recent edited docs after the prod push of today, I suspect. A contributor emailed me about it, too. These macros request documents to get a summary, for example (wiki.getPage function in KS). Is requesting the docs blocked for KumaScript? https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/@@iterator https://developer.mozilla.org/en-US/Learn/Getting_started_with_the_web/JavaScript_basics https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Lexical_grammar
Severity: normal → critical
Bumping to blocker, as it happens even on page without any macro in it: https://developer.mozilla.org/en-US/Learn/tutorial/How_to_build_a_web_site
Severity: critical → blocker
Assignee: nobody → lcrouch
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/a9effda97f96e679e262eba2139ae45296f52e62 bug 1126412 - disable banish to un-ban KumaScript https://github.com/mozilla/kuma/commit/a8dba729257d716d8d6dd0058fc06b6ef85dd00c Merge pull request #3024 from groovecoder/disable-banish-1126412 bug 1126412 - disable banish to un-ban KumaScript
https://github.com/mozilla/kuma/pull/3006 added django-banish [1] to ban clients by IP address. It also includes an auto-ban feature for abusive clients - i.e., clients that send too many requests per minute. :jezdez anticipated it would auto-ban KumaScript [2], so I tried to effectively disable the auto-ban feature by setting the threshold to sys.maxint [3]. But, apparently that didn't work. :( So, https://github.com/mozilla/kuma/pull/3024 disables django-banish completely until we can work it out. For which I'll leave this bug open. [1] https://github.com/yourabi/django-banish [2] https://github.com/mozilla/kuma/pull/3006#issuecomment-70130026 [3] https://github.com/mozilla/kuma/pull/3006/files#diff-bdf3ecebd8379ca98cc89e545fc90899R1273
Downgrading from blocker to major now that the content isn't completely borked.
Severity: blocker → major
Summary: Undefined KumaScript error → Undefined KumaScript error caused by new rate limiting code
Note: :jamon and I are enhancing django-banish with a whitelist feature to address this: https://github.com/yourabi/django-banish/pull/21
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.