nsDateTimeFormatUnix.h:23:14 [-Winconsistent-missing-override] 'FormatTime' overrides a member function but is not marked 'override'

RESOLVED FIXED in mozilla38

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks 1 bug)

Trunk
mozilla38
x86_64
Linux
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
clang 3.6 build warnings, on linux:
{
intl/locale/unix/nsDateTimeFormatUnix.h:23:14 [-Winconsistent-missing-override] 'FormatTime' overrides a member function but is not marked 'override'
intl/locale/unix/nsDateTimeFormatUnix.h:30:14 [-Winconsistent-missing-override] 'FormatTMTime' overrides a member function but is not marked 'override'
intl/locale/unix/nsDateTimeFormatUnix.h:37:14 [-Winconsistent-missing-override] 'FormatPRTime' overrides a member function but is not marked 'override'
intl/locale/unix/nsDateTimeFormatUnix.h:44:14 [-Winconsistent-missing-override] 'FormatPRExplodedTime' overrides a member function but is not marked 'override'
}
(Assignee)

Comment 1

4 years ago
Posted patch fix v1Splinter Review
Attachment #8555425 - Flags: review?(ehsan)

Comment 2

4 years ago
Comment on attachment 8555425 [details] [diff] [review]
fix v1

blanket r=me for all fixes of this nature across the tree.  :-)
Attachment #8555425 - Flags: review?(ehsan) → review+
(Assignee)

Comment 3

4 years ago
Sweet, thanks!

This and bug 1126438 are actually the last instances of this that I get, locally, outside of skia! :)

Comment 5

4 years ago
(In reply to Daniel Holbert [:dholbert] from comment #3)
> This and bug 1126438 are actually the last instances of this that I get,
> locally, outside of skia! :)

Don't think for a second that people will stop putting more of these in.  ;-)  I have "fixed" MIR.h at least three times, if not more.
(Assignee)

Comment 6

4 years ago
True. I will take full advantage of your blanket-r+ then. :)
https://hg.mozilla.org/mozilla-central/rev/f579eea5dc02
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.