1126514 - Add Fennec tile IDs for built in tiles

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

Now that we have both client and server side support for tiles tracking, we can go ahead and add IDs to the included Fennec tiles.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Add tile IDs to Fennec tiles

From Olivier's email:

> Namely, here are the ID's for the STAR/en-US deployment:
> 
> 629: Firefox Marketplace
> 630: Customize Firefox
> 631: Firefox Help and Support
> 632: The Mozilla Project

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8555498 [details] [diff] [review]
Add tile IDs to Fennec tiles

Is this upliftable?

Comment 3

[Brian Nicholson (:bnicholson)]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> Is this upliftable?

We decided that we probably don't need to uplift this since pings for the built-in tiles aren't too important. It is important that tile pings in general are working, though, so I'll ping Olivier once this hits Nightly to make sure the stats are coming in.

https://hg.mozilla.org/integration/fx-team/rev/cebdafba3a85

Comment 4

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/fx-team/rev/54996bae1084 for robocop bustage, https://treeherder.mozilla.org/logviewer.html#?job_id=1850830&repo=fx-team

Comment 5

[Brian Nicholson (:bnicholson)]

Updated testDistribution to include the new tile IDs in the expected results.

https://hg.mozilla.org/integration/fx-team/rev/862aa2eefafe

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/862aa2eefafe

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8555498 [details] [diff] [review]
Add tile IDs to Fennec tiles

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: We want more testing across channels
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: Low risk and limited to built-in tiles
[String/UUID change made/needed]: none

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8555498 [details] [diff] [review]
Add tile IDs to Fennec tiles

OK. Looks like a very low risk patch. We can take this before the merge to Beta. Aurora+

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8555498 [details] [diff] [review]
Add tile IDs to Fennec tiles

So, with the changes being in region.properties the l10n hook blocked this change for landing. I don't know if this will be a problem for l10n's tooling but mfinkle told me that this can reasonably wait for 38 so let's just do that. Aurora-

Comment 10

[Brian Nicholson (:bnicholson)]

Mardak confirmed that since 38 shipped (week 14 of 2015), we are indeed collecting clicks:

[15:23:00]  <Mardak> 2015,14,629,Firefox Marketplace,0,93,0,0,0,0
[15:23:01]  <Mardak> 2015,14,630,Customize Firefox,0,254,0,0,0,0
[15:23:02]  <Mardak> 2015,14,631,Firefox Help and Support,0,58,0,0,0,0
[15:23:03]  <Mardak> 2015,14,632,The Mozilla Project,0,121,0,0,0,0
[15:23:05]  <Mardak> year,week,tile_id,tile_title,impressions,clicks,pinned,blocked,sponsored,sponsored_link