Minimize use of JSON fixture

RESOLVED FIXED

Status

Webtools
Air Mozilla
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: peterbe, Unassigned)

Tracking

Trunk
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
The json fixture we use [0] contains creation of objects that we only rarely use. We should remove as much as we possibly can from this file. 

[0] https://github.com/mozilla/airmozilla/blob/master/airmozilla/manage/tests/main_testdata.json
(Reporter)

Comment 1

3 years ago
It might be worth putting some of the fixtures into setUp() methods too.

Comment 2

3 years ago
Commit pushed to master at https://github.com/mozilla/airmozilla

https://github.com/mozilla/airmozilla/commit/4aa24dac7ce92013ec962871b95a73219857b419
fixes bug 1126528 - Minimize use of JSON fixture

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Reporter)

Comment 3

3 years ago
I measured every single SQL query that was sent to PG during the full test. I filtered it by all INSERTS.

Before this work, there was 9071 inserts. 
After, only 6357
You need to log in before you can comment on or make changes to this bug.