fix implicit uint32_t to bool conversion in DocAccessibleParent::RecvShow return statement

RESOLVED FIXED in mozilla38

Status

()

Core
Disability Access APIs
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla38
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
As discussed in bug 1124821 comment 21, DocAccessibleParent's "RecvShow" method returns bool, but it ends with:
 return consumed;
where 'consumed' is a uint32_t.

This looks superficially like a bug, though it actually is what tbsaunde intended. (i.e. we return true IFF consumed is nonzero)

I'm filing this bug on clarifying this return statement so it doesn't look as much like a mistake.
(Assignee)

Comment 1

3 years ago
Created attachment 8555509 [details] [diff] [review]
fix v1: just add "!= 0" to return statement
Attachment #8555509 - Flags: review?(tbsaunde+mozbugs)
Attachment #8555509 - Flags: review?(tbsaunde+mozbugs) → review+
(Assignee)

Comment 2

3 years ago
Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/c5e6fd99bcb8
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/c5e6fd99bcb8
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.