Closed
Bug 1126541
Opened 9 years ago
Closed 9 years ago
fix implicit uint32_t to bool conversion in DocAccessibleParent::RecvShow return statement
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: dholbert, Assigned: dholbert)
Details
Attachments
(1 file)
1.01 KB,
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
As discussed in bug 1124821 comment 21, DocAccessibleParent's "RecvShow" method returns bool, but it ends with: return consumed; where 'consumed' is a uint32_t. This looks superficially like a bug, though it actually is what tbsaunde intended. (i.e. we return true IFF consumed is nonzero) I'm filing this bug on clarifying this return statement so it doesn't look as much like a mistake.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8555509 -
Flags: review?(tbsaunde+mozbugs)
Updated•9 years ago
|
Attachment #8555509 -
Flags: review?(tbsaunde+mozbugs) → review+
Assignee | ||
Comment 2•9 years ago
|
||
Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/c5e6fd99bcb8
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/c5e6fd99bcb8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•