Closed Bug 1126546 Opened 9 years ago Closed 9 years ago

Make PLDHashTable::keyHash private

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla38

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

Attachments

(1 file)

Once bug 1124973's patches land, PLDHashTable::keyHash can be made private.
As well as renaming and privatizing |keyHash|, this patch also:

- renames GetKeyHash() to ComputeKeyHash(), which better indicates it's not
  some kind of getter function; and

- makes PLDHashEntryStub inherit from PLDHashEntryHdr, for consistency with
  everywhere else.
Attachment #8555513 - Flags: review?(nfroyd)
Comment on attachment 8555513 [details] [diff] [review]
Make PLDHashTable::keyHash private

Review of attachment 8555513 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/glue/pldhash.h
@@ +486,5 @@
>   * aTable->mOps->initEntry is non-null and aTable->mOps->initEntry op has
>   * returned false.
>   *
> + * Otherwise, aEntry->mKeyHash has been set so that
> + * PLDHashTAble::EntryIsFree(entry) is false, and it is up to the caller to

Nit: PLDHashTable::
Attachment #8555513 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/ec461a53b084
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: