1126653 - don't send nfc-manager-tech-lost if the foreground has received ontag/peerfound.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

This is a follow-up in Bug 1082443.
In Bug 1082443 we broadcast nfc-manager-tech-discovered when app cannot handle this. But if the app could handle the event, when the tag/peer is removed, we still send nfc-manager-tech-lost to System app, which is inconsistent.

We should also prevent sending nfc-manager-tech-lost if the app has received ontag/peerfound before.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch. v2

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/147167067e99

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8555650 [details] [diff] [review]
Patch. v2

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
Bug 1082443

User impact if declined: 
Phone will still vibrate even the foreground app has processed NFC event.

Testing completed: 
Manually.

Risk to taking this patch (and alternatives if risky): 
No.

String or UUID changes made by this patch:
Update uuid in nsINfcContentHelper.idl, which is an internal IDL.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/147167067e99

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/242eb3edf1bf