Closed
Bug 1126655
Opened 9 years ago
Closed 9 years ago
SyntaxError: test for equality (==) mistyped as assignment (=)? VariablesView.jsm:2058:41
Categories
(DevTools :: Debugger, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 38
People
(Reporter: dholbert, Unassigned)
References
Details
Attachments
(1 file)
1.00 KB,
patch
|
vporof
:
review+
|
Details | Diff | Splinter Review |
Just noticed this go by in my error console, after opening up devtools: { SyntaxError: test for equality (==) mistyped as assignment (=)? VariablesView.jsm:2058:41 } That points to this line: > while (topView = parentView.ownerView) { http://mxr.mozilla.org/mozilla-central/source/browser/devtools/shared/widgets/VariablesView.jsm#2058 Looks like the assignment is intentional there. We just need to add an extra layers of parens around that while condition to silence this warning.
Reporter | ||
Comment 1•9 years ago
|
||
Attachment #8555636 -
Flags: review?(vporof)
Updated•9 years ago
|
Attachment #8555636 -
Flags: review?(vporof) → review+
Reporter | ||
Comment 2•9 years ago
|
||
Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/0f7b2674c64a
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/0f7b2674c64a
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•