Closed Bug 1126655 Opened 9 years ago Closed 9 years ago

SyntaxError: test for equality (==) mistyped as assignment (=)? VariablesView.jsm:2058:41

Categories

(DevTools :: Debugger, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 38

People

(Reporter: dholbert, Unassigned)

References

Details

Attachments

(1 file)

Just noticed this go by in my error console, after opening up devtools:
{
SyntaxError: test for equality (==) mistyped as assignment (=)?
   VariablesView.jsm:2058:41
}

That points to this line:
>    while (topView = parentView.ownerView) {
http://mxr.mozilla.org/mozilla-central/source/browser/devtools/shared/widgets/VariablesView.jsm#2058

Looks like the assignment is intentional there. We just need to add an extra layers of parens around that while condition to silence this warning.
Attached patch fix v1Splinter Review
Attachment #8555636 - Flags: review?(vporof)
Attachment #8555636 - Flags: review?(vporof) → review+
https://hg.mozilla.org/mozilla-central/rev/0f7b2674c64a
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: