Closed Bug 1126700 Opened 9 years ago Closed 7 years ago

Use something better than rel="mobile" to specify search activity search URL

Categories

(Firefox for Android Graveyard :: Search Activity, defect)

35 Branch
All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: Margaret, Unassigned)

References

Details

We implemented support for this rel="mobile" attribute in bug 1063193 in order to make sure the search activity results wouldn't redirect on wikipedia.

However, since fixing bug 1107925, I don't think this should actually be a problem in practice anymore.

Now we're using this rel="mobile" as a way to specify urls for the search activity, but something like rel="searchactivity" would be much more intuitive.
I'd rather not change this, or at least not do it without backwards compat.

It seems that'd make a lengthy day for flod, http://mxr.mozilla.org/l10n-mozilla-aurora/search?string=%22mobile%22&find=mobile%2Fsearchplugins%2F*&findi=&filter=^%5B^\0%5D*%24&hitlimit=&tree=l10n-mozilla-aurora, more than anything else :-/
(In reply to Axel Hecht [:Pike] from comment #1)
> I'd rather not change this, or at least not do it without backwards compat.
> 
> It seems that'd make a lengthy day for flod,
> http://mxr.mozilla.org/l10n-mozilla-aurora/
> search?string=%22mobile%22&find=mobile%2Fsearchplugins%2F*&findi=&filter=^%5B
> ^\0%5D*%24&hitlimit=&tree=l10n-mozilla-aurora, more than anything else :-/

It looks like those are all used for the wikipedia case, which was used to fix bug 1063193. I'd have to test out this theory myself, but I suspect that with the fix for bug 1107925, if we just ignore that rel="mobile", things should work as expected.

It would be good to clean up these search plugins to remove those extra <Url> tags, but there wouldn't be a big rush to do it if this is the case.

But thank you for pointing that out, I'll make sure to maintain backwards compatibility!
This is an ex-Search Activity now (bug 1221344).
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.