Closed Bug 1126720 Opened 5 years ago Closed 5 years ago

[Bluetooth] Port bugs 1129846, 1129257, 1119746, 1065336 and 1124565 to bluetooth2

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox38 fixed)

RESOLVED FIXED
2.2 S6 (20feb)
Tracking Status
firefox38 --- fixed

People

(Reporter: tzimmermann, Assigned: tzimmermann)

References

Details

Attachments

(6 files)

Those patches are for establishing and using the connection to the Bluetooth daemon. We can port them in a single step, and finally get bluetooth2/ switched over to bluetoothd as well.
Depends on: 1131653
Depends on: 1129846, 1129257
Summary: [Bluetooth] Port bugs 1119746, 1065336 and 1124565 to bluetooth2 → [Bluetooth] Port bugs 1129846, 1129257, 1119746, 1065336 and 1124565 to bluetooth2
Jocelyn, Ben,

I have ported the remaining daemon patches to blueooth2/. That would also mean that it would become the default backend. But we're still fixing bugs in bluetoothd and it doesn't support GATT yet. Do you want to stay on the old Bluedroid backend for a little longer? I'd change the patch accordingly.

No matter what the default backend is, you could switch between backends by settings  ro.moz.bluetooth.backend  to either  bluedroid  or  bluetoothd .
Flags: needinfo?(joliu)
Flags: needinfo?(btian)
Hi Thomas,

Since 2.2 is still in stabilization stage, I want to stay on the old bluedroid backend as default at this moment.
That would also be easier for me since I'm already working on GATT API implementations.

I don't have concerns as long as bluedroid is still the default backend for bluetooth2.
Is that OK to you?

Thanks,
Jocelyn
Flags: needinfo?(joliu)
(In reply to jocelyn [:jocelyn] from comment #2)
> Hi Thomas,
> 
> Since 2.2 is still in stabilization stage, I want to stay on the old
> bluedroid backend as default at this moment.
> That would also be easier for me since I'm already working on GATT API
> implementations.
> 
> I don't have concerns as long as bluedroid is still the default backend for
> bluetooth2.
> Is that OK to you?

Sure, thanks for the feedback.
Flags: needinfo?(btian)
Comment on attachment 8562768 [details] [diff] [review]
[01] Bug 1126720: Handle all used type in PDU explicitly (under bluetooth2/)

Review of attachment 8562768 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8562768 - Flags: review?(btian) → review+
Comment on attachment 8562769 [details] [diff] [review]
[02] Bug 1126720: Use |int32_t| for |Channel| in Bluetooth Socket HAL (under bluetooth2/)

Review of attachment 8562769 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8562769 - Flags: review?(btian) → review+
Comment on attachment 8562771 [details] [diff] [review]
[03] Bug 1126720: Fix ref-counting of bluetoothd channels (under bluetooth2/)

Review of attachment 8562771 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8562771 - Flags: review?(btian) → review+
Comment on attachment 8562772 [details] [diff] [review]
[04] Bug 1126720: Listen for socket connections when starting Bluetooth (under bluetooth2/)

Review of attachment 8562772 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8562772 - Flags: review?(btian) → review+
Comment on attachment 8562774 [details] [diff] [review]
[05] Bug 1126720: Support random postfix for Bluetooth daemon socket name (under bluetooth2/)

Review of attachment 8562774 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8562774 - Flags: review?(btian) → review+
Comment on attachment 8562777 [details] [diff] [review]
[06] Bug 1126720: Implement Bluetooth backend selection; use Bluedroid by default (under bluetooth2/)

Review of attachment 8562777 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8562777 - Flags: review?(btian) → review+
You need to log in before you can comment on or make changes to this bug.