Closed
Bug 1126721
Opened 11 years ago
Closed 11 years ago
[Loop] "Rooms list" screen is shown before message "Full room"
Categories
(Firefox OS Graveyard :: Gaia::Loop, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: lolimartinezcr, Assigned: borjasalguero)
Details
(Whiteboard: [Room1.1.1_TestRun2][In 1.1.1][loop approved for 1.1.1])
Attachments
(1 file)
Fire E 2.0
Loop 1.1.1/d4d6d37
Pre-requisites
User A logged in Mobile Loop application with FxA
User B logged in Destkop Loop application.
User C logged in Mobile Loop application with MobileID.
User A has created and shared a room with contact B and C.
STRs:
1. User A has joined to room (owner).
2. User B has joined to room (invited).
3. User C taps on Message application, taps on message received, clicks in URL shared and clicks on "Join the conversation" in StandaloneUI.
4. User C selects camera and taps on "Join" button.
Actual result:
Room list is shown a few seconds and after appear message about "Full room". Please see video http://youtu.be/9my48JrtVD4
Expect
Message about "full room" is directly shown.
|
Reporter | |
Updated•11 years ago
|
Summary: [Loop] "Rooms list" is shown before message "Full room" → [Loop] "Rooms list" screen is shown before message "Full room"
Whiteboard: [Room1.1.1_TestRun2]
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → borja.bugzilla
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8556389 -
Flags: review?(crdlc)
|
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8556389 [details] [review]
Pull Request
Left a nit, LGTM, perfect!
Attachment #8556389 -
Flags: review?(crdlc) → review+
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Whiteboard: [Room1.1.1_TestRun2] → [Room1.1.1_TestRun2][Not in 1.1.1]
|
|
||
Comment 3•11 years ago
|
||
Although the Room list is still shown, the time you can see it has decreased a lot.
Minor issue but very low risk patch, so giving the approval for the uplifting.
Borja, could you be so kind of landing the patch in 1.1.1 branch? Thanks a lot!
Severity: normal → minor
Flags: needinfo?(borja.bugzilla)
Whiteboard: [Room1.1.1_TestRun2][Not in 1.1.1] → [Room1.1.1_TestRun2][Not in 1.1.1][loop approved for 1.1.1]
|
|
Assignee | |
Comment 4•11 years ago
|
||
https://github.com/mozilla-b2g/firefoxos-loop-client/commit/72f7ef5675e4e37b8eccbc599d6701c6c4531f63
Merged in v1.1.1 branch
Flags: needinfo?(borja.bugzilla)
|
|
||
Updated•11 years ago
|
Whiteboard: [Room1.1.1_TestRun2][Not in 1.1.1][loop approved for 1.1.1] → [Room1.1.1_TestRun2][In 1.1.1][loop approved for 1.1.1]
|
|
Reporter | |
Comment 5•11 years ago
|
||
Tested and I can *still* see the rooms list but *inmediately* it changes to the message about busy.
Fire E 2.0
Loop 1.1.1/39a5284
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•