1126723 - mp3 audio streaming start is delayed [intermittent]

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Ada [:adalucinet]]

logged as requested in bug 1121148 comment 17

Reproducible on Nightly 38.0a1 (Build ID: 20150127030230) *only* with e10s enabled
Platform: Mac OS X 10.10

Steps to reproduce:
1. Navigate to http://radiobattletoads.com/test_mozilla.php
2. Click on Play radio (mp3) button

Expected results: Audio starts in 1, 2 seconds.

Actual results: Audio is delayed.

Comment 1

[Ada [:adalucinet]]

Attachment: log

Comment 2

[Bobby Holley (:bholley)]

Thanks for the bug report. Looks like this affects the media code in general (not just Nightly), and it's just an issue of e10s altering the timing and getting us to go into buffering mode before we finish prerolling.

I reproduced those conditions artificially, and found a number of bugs. I'll work up some patches.

Comment 3

[Bobby Holley (:bholley)]

Attachment: Part 1 - Don't store bogus durations. v1

The apple MP3 decoder passes in garbage for this particular live stream. Let's
validate our inputs.

Comment 4

[Bobby Holley (:bholley)]

Attachment: Part 2 - Bail out of HasLowUndecodedData if we don't have a duration. v1

GetEstimatedBufferedTimeRanges returns an empty range if the duration is -1.

Comment 5

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=00d195262681

Comment 6

[Bobby Holley (:bholley)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/20a6417016df
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/16df4e462d80

Comment 7

[Bobby Holley (:bholley)]

Comment on attachment 8563522 [details] [diff] [review]
Part 2 - Bail out of HasLowUndecodedData if we don't have a duration. v1

Flagging for aurora/beta approval. Not sure if it's too late for beta - if it is it's probably ok. This is basically the same regression as bug 1121148, but more intermittent. We've only seen this in practice with e10s, because it's very timing dependent.

Approval Request Comment
[Feature/regressing bug #]:bug 1091008
[User impact if declined]: potential 30-second delay when buffering a video
[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: Low. But given where we are in the cycle, that still might be too much for beta.
[String/UUID change made/needed]: None

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8563522 [details] [diff] [review]
Part 2 - Bail out of HasLowUndecodedData if we don't have a duration. v1

We are going to build a beta 10. Not sure that we will take it or not right now.
Anyway, we probably want that in aurora.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/20a6417016df
https://hg.mozilla.org/mozilla-central/rev/16df4e462d80

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8563522 [details] [diff] [review]
Part 2 - Bail out of HasLowUndecodedData if we don't have a duration. v1

Taking it in beta 10 too. We will be able to backout this change in the RC build if it creates regressions.

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8563522 [details] [diff] [review]
Part 2 - Bail out of HasLowUndecodedData if we don't have a duration. v1

Oh, e10s specific. Not taking it.

Comment 12

[Bobby Holley (:bholley)]

(In reply to Sylvestre Ledru [:sylvestre] from comment #11)
> Comment on attachment 8563522 [details] [diff] [review]
> Part 2 - Bail out of HasLowUndecodedData if we don't have a duration. v1
> 
> Oh, e10s specific. Not taking it.

The reporter was only able to reproduce the issue with e10s, but the actual bug could happen for any other reason that changes timing (i.e. network traffic patterns).

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8563522 [details] [diff] [review]
Part 2 - Bail out of HasLowUndecodedData if we don't have a duration. v1

OK

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1220d2300693
https://hg.mozilla.org/releases/mozilla-aurora/rev/0e0c3bcaeb0e

https://hg.mozilla.org/releases/mozilla-beta/rev/4f90bd0f1348
https://hg.mozilla.org/releases/mozilla-beta/rev/bbd9460d9987