1126755 - Use weak references for |browser|s in UITour

Status: RESOLVED INVALID

(Firefox :: Tours, defect)

Description

[Alessio Placitelli [:Dexter]]

Using UITour functions from a browser with no tab causes the window to leak.

A short-term solution could be to use weak references in places like [1], using the |Components.utils.getWeakReference| API[2].

[1] - https://dxr.mozilla.org/mozilla-central/source/browser/components/uitour/UITour.jsm#639
[2] - https://developer.mozilla.org/en-US/docs/Components.utils.getWeakReference

Comment 1

[Matthew N. [:MattN]]

I realized afterwards that the problem with this solution is that 2 weak references to the same <browser> won't be treated as the same in the Set so I think we should go with replacing TabClose instead.

Comment 2

[Alessio Placitelli [:Dexter]]

(In reply to Matthew N. [:MattN] from comment #1)
> I realized afterwards that the problem with this solution is that 2 weak
> references to the same <browser> won't be treated as the same in the Set so
> I think we should go with replacing TabClose instead.

Good point. Can I close this one then?

Comment 3

[Matthew N. [:MattN]]

Sure