1126781 - browser-search-autocomplete-result-popup's popupshowing handler shouldn't clobber the popup's style attribute

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Dão Gottwald [:dao]]

browser-search-autocomplete-result-popup's popupshowing handler sets the min-width on the popup like this:

  panel.setAttribute("style", "min-width: " + minWidth + "px");

(http://hg.mozilla.org/mozilla-central/annotate/b2b10231606b/browser/base/content/urlbarBindings.xml#l1176)

Instead, it should set panel.style.minWidth directly.

Comment 1

[Giovanny Gongora [:gioyik]]

The solution could be:

panel.style.minWidth(minWidth);

or should I add the "px" too? Something like:

panel.style.minWidth(minWidth + "px");

Comment 2

[Dão Gottwald [:dao]]

minWidth isn't a function, it's a property that needs to be set like foo.minWidth = ...;

And yes, "px" needs to be added.

Comment 3

[Giovanny Gongora [:gioyik]]

So, the correct way could be:

panel.minWidth = minWidth + "px";

I ask before send a patch to be sure. :)

Comment 4

[Dão Gottwald [:dao]]

panel.style.minWidth, not panel.minWidth

Comment 5

[Giovanny Gongora [:gioyik]]

Attachment: 1126781.patch

Patch

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8556817 [details] [diff] [review]
1126781.patch

Thanks!

Comment 7

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/fx-team/rev/93a250d4877c

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/93a250d4877c