1126785 - Speculative Conn (and Predictive Conn) Telemetry is wrong

Status: NEW

(Core :: Networking: HTTP, defect, P3)

Description

[Patrick McManus [:mcmanus]]

The telemetry declares a connection used/unused based on its status during the half-open stage.

It should be based on whether or not it ever carries a transaction - not whether or not it is deemed needed during the tcp handshake.. it could also be found useful during ssl handshake or even in the idle connection pool.

Comment 1

[Patrick McManus [:mcmanus]]

The telemetry in questiOn:
HTTPCONNMGR_TOTAL_SPECULATIVE_CONN (this is probably fine)
HTTPCONNMGR_USED_SPECULATIVE_CONN
HTTPCONNMGR_UNUSED_SPECULATIVE_CONN

I would suggest that if the halfopen is from speculative connect you should transfer that information into the single place nsHttpConnection is created.. and then when nshttpConnection is destroyed it can mark used or unused based on mExperienced iff it came from speculative. You will also need to deal with the case where a nshttpconnection is never created for that halfopen. (i.e. the half open will probably need a new bit - not just marking whether or not it was speculative, but also whether that had been sent into nshttpconnection for this purpose)

Comment 2

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 3

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258