1126807 - Listing collections have Promo collections background color in Consumer Pages

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[Valentina Virlics [:vvalentina], Ecosystem QA]

Steps to reproduce:
1. Sign in to MP-dev Curation Tools page https://marketplace-dev.allizom.org/curate
2. Create a listing collection 
3. Publish the created collection (i.e. test-white-names-collection)

Expected results:
The published collection is listed in Consumer Pages and has no display or layout issues.

Actual results:
The created listing collection is displayed in Consumer Pages with the default background color of promo collection.

Notes/Issues:
Verified on FF38 (Win 7).
Screencast for this issue http://screencast.com/t/DupLucyX

Comment 1

[Kevin Ngo [:ngoke]]

This was fixed a while ago, but it seems like -dev didn't deploy. Deploying now.

Expected:

Listing collections are created with a color picker.

Comment 2

[David Durst [:ddurst]]

Is this a change?

Listing collections aren't created with a color picker -- promo collections are.

Has that changed?

Comment 3

[Kevin Ngo [:ngoke]]

Yes, all collection landing pages need a color.

Comment 4

[Kevin Ngo [:ngoke]]

^ May not be officially specced, but it's how it is now and it makes sense.

Comment 5

[David Durst [:ddurst]]

Pwalm is under a different impression, so someone needs to be tie-breaker :)

Comment 6

[Kevin Ngo [:ngoke]]

Okay, I see the mocks with the grey-colored listing collections.

That makes it a bit tough because we have:

- Promo collections have colors.
- Listing collections are styled like editorial brands without the icon.
- Brands will soon have colors.

I sort of have collection styles grouped together so it is technically easier if we just had all collections have a color :/

Comment 7

[Valentina Virlics [:vvalentina], Ecosystem QA]

 (In reply to Kevin Ngo [:ngoke] from comment #6)
> Okay, I see the mocks with the grey-colored listing collections.
> 
> That makes it a bit tough because we have:
> 
> - Promo collections have colors.
> - Listing collections are styled like editorial brands without the icon.
> - Brands will soon have colors.
> 
> I sort of have collection styles grouped together so it is technically
> easier if we just had all collections have a color :/

According to comment #6 this issue is verified as fixed on MP-dev on FF38 (Win 7).
Postfix screencast http://screencast.com/t/rMjS5sovdo

Comment 8

[David Durst [:ddurst]]

This does affect the overall design.

Pwalm needs to weigh in on the detail page having a color, but also in the impact on the feed itself -- for listing collections, the feed representation shouldn't be showing a color.

But that was before, when it didn't have one. Seems like we can not show it on the feed and still show it on the detail page, but let's make that call deliberately.

(And, I guess by association, we need to make the color selection available in transonic as well.)