Closed Bug 1126808 Opened 5 years ago Closed 5 years ago

Mark /xpcom/build as FAIL_ON_WARNINGS

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

With bug 1126790 fixed, /xpcom/build is warning-free in my local build.

Filing this bug to track marking it as FAIL_ON_WARNINGS.
Attached patch fix v1Splinter Review
Here's the patch, though of course we'll need a Try run (and likely a few warning-fixes for other platforms) before this can land.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #8555878 - Flags: review?(nfroyd)
Comment on attachment 8555878 [details] [diff] [review]
fix v1

Review of attachment 8555878 [details] [diff] [review]:
-----------------------------------------------------------------

r=me when it compiles.
Attachment #8555878 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/9ecd3b1a151f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.