1126865 - Minor refactoring of GCRuntime::incrementalCollectSlice() and sweepPhase()

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Comment 1

[Jon Coppeard (:jonco)]

Attachment: bug1126865-refactor-sweepPhase

Factor out a function to sweep a list of arenas from GCRuntime::sweepPhase().

Comment 2

[Jon Coppeard (:jonco)]

Attachment: bug1126865-refactor-ics

Use an enum to indicate whether an incremental collection phase has finished or not, and get rid of 'bool finished' in GCRuntime::incrementalCollectSlice().

Comment 3

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8555936 [details] [diff] [review]
bug1126865-refactor-ics

Review of attachment 8555936 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsgc.cpp
@@ +5291,5 @@
>  
>          endSweepingZoneGroup();
>          getNextZoneGroup();
>          if (!currentZoneGroup)
> +            return Finished;  /* We're finished. */

Please eliminate this comment and all of the /* Yield to the mutator. */ comments now. I liked having them before your change, but they were never consistently applied, and your enum is *way* better.

Comment 4

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8e450ff88d61
https://hg.mozilla.org/integration/mozilla-inbound/rev/4aa870ca28d6

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4aa870ca28d6
https://hg.mozilla.org/mozilla-central/rev/8e450ff88d61