Deal with regions in elastic search

VERIFIED FIXED in 2015-05-12

Status

Marketplace
Search
P3
normal
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: Andy McKay, Assigned: mat)

Tracking

Avenir
2015-05-12
x86
Mac OS X
Points:
---

Details

(Reporter)

Description

3 years ago
Rob can add more details here, but I'm filing this so we don't forget. Basically the way we store data in ES is going to bloat if we add in every region. We need to be able to cope with that.
We store a region specific value for both popular and trending values. I don't think there's anything we can do about this exploding out to 250+ fields for each of popular/trending since we will need to sort on these.

But, we can reduce the "over the wire" size by using `.fields(...)` to choose the subset of fields we need ES to return to us when making queries. The popular and trending fields don't need to be in this list since we don't expose these in the API. I'm sure there are others.
(Assignee)

Comment 2

3 years ago
While we are trying to reduce "over the wire" size, we could consider doing the same thing you propose for regions for translations. We could also have a general blacklist/whitelist, maybe stored in the serializers, to avoid requesting fields we know we are not going to need/expose.
(Reporter)

Updated

3 years ago
Priority: -- → P4
(Assignee)

Updated

3 years ago
Priority: P4 → P3
Target Milestone: --- → 2015-05-12
(Assignee)

Updated

3 years ago
Assignee: nobody → mpillard
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 3

3 years ago
Fixed in https://github.com/mozilla/zamboni/commit/927bad0ebc7ed1cd693a730bfdfc77e73a45d0c1

QA:
- Please make sure search, new, popular pages still work.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Comment 4

3 years ago
Verified as fixed for all fields from above
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.