1127226 - [Wifi] Modify wifi power saving mode on gaia.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Amy Chung [:Amy]]

Attachment: [WIFI] While screen on WiFi do not enter power save mode when there is no traffic

Base on Bug 1084156 [WIFI] While screen on WiFi do not enter power save mode when there is no traffic, already added power saving when wifi init.
So it doesn't need to turn on power saving mode when screen off and unplugged.

Comment 1

[Amy Chung [:Amy]]

Attachment: Modified power saving mode when screen off and unplugged.

Dear Seinlin,
I have removed the power saving mode when screen off and unplugged, and modified unit test case.
Please help me to confirm this modification.

Comment 2

[Kai-Zhen Li [:seinlin][:kli]]

I left comments on PR, please have a look.

Comment 3

[Amy Chung [:Amy]]

Dear Seinlin,
I have removed the power saving mode when wifi wake lock, and modified unit test case.
Please help me to confirm this modification.

Thanks!

Comment 4

[Kai-Zhen Li [:seinlin][:kli]]

Amy, I notice the following two points:

1. I think 'Test wifi should be turned on and in power saving mode' should be modified only. It should not be removed entirely.

2. Please also modify 'Test wifi should stay disabled', as comment on PR.

Could you also go through other test cases with similar conditions?

Comment 5

[Kai-Zhen Li [:seinlin][:kli]]

Comment on attachment 8568438 [details] [review]
Modified power saving mode when screen off and unplugged.

Cancel the request. Ping me again when you finished as my comment.

Comment 6

[Amy Chung [:Amy]]

Dear Seinlin,
I modified the unit test case and sleep function in wifi.js.
Please help me to review it.
Thanks!

Comment 7

[Kai-Zhen Li [:seinlin][:kli]]

Comment on attachment 8568438 [details] [review]
Modified power saving mode when screen off and unplugged.

Arthur, In bug 1084156, wifi power save mode is controlled in gecko. So I think the control in system app should be removed.

Could you review this patch? Thanks!

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8568438 [details] [review]
Modified power saving mode when screen off and unplugged.

It would be better to have system owner/peer review this patch. Redirect the request to Alive.

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8568438 [details] [review]
Modified power saving mode when screen off and unplugged.

There is one testing failure and several linting errors, please fix them.
The unit test failure is because you removed the declaration of 'request' but used it at https://github.com/tefn3849/gaia/blob/wifi_1127226/apps/system/js/wifi.js#L284

Comment 10

[Amy Chung [:Amy]]

Dear Seinlin,
I have modified it, please help me to confirm it.
Thanks!

Comment 11

[Kai-Zhen Li [:seinlin][:kli]]

From try result, unit test is passed. But there is a gjslint error
--
TEST-UNEXPECTED-FAIL | apps/system/test/unit/wifi_test.js | Line 443, E:0121: Illegal comma at end of object literal
--

You should fix this and then request for review from alive.

Comment 12

[Amy Chung [:Amy]]

Dear Seinlin,
I have modified it, please help me to confirm it.
Thanks!

Comment 13

[Kai-Zhen Li [:seinlin][:kli]]

Test result looks good.

Comment 14

[Amy Chung [:Amy]]

Comment on attachment 8568438 [details] [review]
Modified power saving mode when screen off and unplugged.

Dear Alive,
Please help me to review this patch.
Thanks!

Comment 15

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8568438 [details] [review]
Modified power saving mode when screen off and unplugged.

r=me with nits addressed: remove unwanted stub and restore.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/8085188e5c723c43d76d386a626e03a713748d98