Closed Bug 1127237 Opened 5 years ago Closed 5 years ago

Text from history panel is not entirely displayed

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 38
Tracking Status
firefox36 + verified
firefox37 + verified
firefox38 --- verified
fennec 38+ ---

People

(Reporter: CristinaM, Assigned: ally)

References

Details

(Whiteboard: [small device][wip])

Attachments

(3 files)

Environment:
Device: Samsung Galaxy R (Android 2.3.4)
Build: Firefox for Android (2015-01-28)

Steps:
1. Launch Fennec;
2. Go to History panel and tap on Clear browsing history.

Expected results:
The entire text is displayed 'Websites you visited most recently show up here.'

Actual results:
Text is not entirely displayed.

Please see the attachment. 
Probably Bug 1091461 caused this.
I can't reproduce this on my Nexus 6. Small screens only?
tracking-fennec: --- → ?
I am not able to reproduce the issue on Motorola Razr (Android 4.1.2) rez:540x960 or Samsung Galaxy S4 (Android 4.4.2) rez:1080x1920. Probably specific to small screen devices, like I mentioned in description I was using Samsung Galaxy R (Android 2.3.4) rez:480x800.
Can you help find a regression range?
Flags: needinfo?(cristina.madaras)
Assignee: nobody → ally
tracking-fennec: ? → 38+
Whiteboard: [waiting on regression range][small device needed]
Allison you can use the HTC Desire S or Motorola Razr in the filing cabinet of my desk.
Regression window:
mozilla-central
Last good: 38e4719e71af
First bad: b2b10231606b
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=38e4719e71af&tochange=b2b10231606b
Flags: needinfo?(cristina.madaras)
d79a930a61f1	Allison Naaktgeboren — Bug 1091461 - Fix Tapping anywhere under the 'Private Browsing' tip in the History panel will open the Custom menu when it shouldn't.r=liuche

Is in that range
Blocks: 1091461
Whiteboard: [waiting on regression range][small device needed] → [small device needed]
Whiteboard: [small device needed] → [small device][shovel-ready]
Whiteboard: [small device][shovel-ready] → [small device][wip]
gingerbread doesnt have the "show layout bounds" dev option. ugh
I have tested this on my small phone, the medium, and the large tablet. It behaves graciously on all 3 in both orientations and has the benefit of getting rid of the clickable area to the sides of the text, which on the tablet are quite large in landscape mode.
Attachment #8558796 - Flags: review?(liuche)
Attachment #8558796 - Flags: review?(liuche) → review+
Comment on attachment 8558796 [details] [diff] [review]
Reviewable version

Approval Request Comment
[Feature/regressing bug #]: bug 1091461 was not a complete fix, and didn't work particularly well for small screens.
[User impact if declined]: small screen users may see some text cut off, or in landscape
[Describe test coverage new/current, TreeHerder]: local
[Risks and why]: very low, xml changes
[String/UUID change made/needed]: none
Attachment #8558796 - Flags: approval-mozilla-beta?
Attachment #8558796 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/integration/fx-team/rev/5b82617f158d
Keywords: checkin-needed
Whiteboard: [small device][wip] → [small device][wip][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/5b82617f158d
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [small device][wip][fixed-in-fx-team] → [small device][wip]
Target Milestone: --- → Firefox 38
Verified as fixed in Firefox for Android 38.0a1 (2015-02-06);
Device: Samsung Galaxy R (Android 2.3.4).
Tracking as this is a noticeable UI polish bug.
Comment on attachment 8558796 [details] [diff] [review]
Reviewable version

This is a visible UI polish bug with a small fix. The fix has also been verified on Nightly. I think we should take this in Beta 8.

Beta+
Aurora+
Attachment #8558796 - Flags: approval-mozilla-beta?
Attachment #8558796 - Flags: approval-mozilla-beta+
Attachment #8558796 - Flags: approval-mozilla-aurora?
Attachment #8558796 - Flags: approval-mozilla-aurora+
Verified as fixed in Firefox for Android 37.0a2 (2015-02-08);
Device: Samsung Galaxy R (Android 2.3.4).
Verified as fixed in Firefox for Android 36 Beta 8;
Device: Samsung Galaxy R (Android 2.3.4).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.