1127237 - Text from history panel is not entirely displayed

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Cristina Madaras, QA [:CristinaM]]

Attachment: device-2015-01-29-104227.png

Environment:
Device: Samsung Galaxy R (Android 2.3.4)
Build: Firefox for Android (2015-01-28)

Steps:
1. Launch Fennec;
2. Go to History panel and tap on Clear browsing history.

Expected results:
The entire text is displayed 'Websites you visited most recently show up here.'

Actual results:
Text is not entirely displayed.

Please see the attachment. 
Probably Bug 1091461 caused this.

Comment 1

[Aaron Train [:aaronmt]]

I can't reproduce this on my Nexus 6. Small screens only?

Comment 2

[Cristina Madaras, QA [:CristinaM]]

I am not able to reproduce the issue on Motorola Razr (Android 4.1.2) rez:540x960 or Samsung Galaxy S4 (Android 4.4.2) rez:1080x1920. Probably specific to small screen devices, like I mentioned in description I was using Samsung Galaxy R (Android 2.3.4) rez:480x800.

Comment 3

[Aaron Train [:aaronmt]]

Can you help find a regression range?

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

Allison you can use the HTC Desire S or Motorola Razr in the filing cabinet of my desk.

Comment 5

[Cristina Madaras, QA [:CristinaM]]

Regression window:
mozilla-central
Last good: 38e4719e71af
First bad: b2b10231606b
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=38e4719e71af&tochange=b2b10231606b

Comment 6

[Aaron Train [:aaronmt]]

d79a930a61f1	Allison Naaktgeboren — Bug 1091461 - Fix Tapping anywhere under the 'Private Browsing' tip in the History panel will open the Custom menu when it shouldn't.r=liuche

Is in that range

Comment 7

[Allison Naaktgeboren :ally]

gingerbread doesnt have the "show layout bounds" dev option. ugh

Comment 8

[Allison Naaktgeboren :ally]

Attachment: colored layout for debugging small devices. lime green is clickable area

Comment 9

[Allison Naaktgeboren :ally]

Attachment: Reviewable version

I have tested this on my small phone, the medium, and the large tablet. It behaves graciously on all 3 in both orientations and has the benefit of getting rid of the clickable area to the sides of the text, which on the tablet are quite large in landscape mode.

Comment 10

[Chenxia Liu [:liuche]]

Comment on attachment 8558796 [details] [diff] [review]
Reviewable version

Approval Request Comment
[Feature/regressing bug #]: bug 1091461 was not a complete fix, and didn't work particularly well for small screens.
[User impact if declined]: small screen users may see some text cut off, or in landscape
[Describe test coverage new/current, TreeHerder]: local
[Risks and why]: very low, xml changes
[String/UUID change made/needed]: none

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/5b82617f158d

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5b82617f158d

Comment 13

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in Firefox for Android 38.0a1 (2015-02-06);
Device: Samsung Galaxy R (Android 2.3.4).

Comment 14

[Lawrence Mandel [:lmandel] (use needinfo)]

Tracking as this is a noticeable UI polish bug.

Comment 15

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8558796 [details] [diff] [review]
Reviewable version

This is a visible UI polish bug with a small fix. The fix has also been verified on Nightly. I think we should take this in Beta 8.

Beta+
Aurora+

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4a1dcf78c799

Comment 17

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in Firefox for Android 37.0a2 (2015-02-08);
Device: Samsung Galaxy R (Android 2.3.4).

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6f3775d5c839

Comment 19

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in Firefox for Android 36 Beta 8;
Device: Samsung Galaxy R (Android 2.3.4).