1127288 - Have headers in in-content prefs for both the DRM checkbox and the popup controls under Preferences -> Content

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Dão Gottwald [:dao]]

In-content prefs are usually grouped with headers. In bug 1111146, I removed the "Pop-ups" header so that I could group that checkbox with the one I added rather than introducing a "DRM Content" header. Having one header per checkbox doesn't really seem useful to me, so I think we'd rather have no header here or a "General" header for both checkboxes (like we do in the Security pane).

If we end up not reinstating the "Pop-ups" header, that string should be removed from content.dtd.

Comment 1

[Sevaan Franks [:sevaan]]

I feel that the headers are important to have as it makes it easier for users to quickly scan a page to find what they want. Without the headers on some prefs users will be pulled out of "quick-scan mode" and they will be forced to read the details.

Also, when search is implemented in about:preferences the headers will be nice to have in surfaced results.

Comment 2

[:Gijs (he/him)]

Per comment #1

Comment 3

[:Gijs (he/him)]

Attachment: add header for DRM checkbox, fix link alignment,

I took the opportunity to fix the alignment of the 'learn more' link (it was 4px out compared to the buttons horizontally, and it was aligned differently in the row than the checkbox text meaning it was off vertically).

Comment 4

[Justin Dolske [:Dolske]]

Comment on attachment 8557460 [details] [diff] [review]
add header for DRM checkbox, fix link alignment,

Review of attachment 8557460 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/preferences/content.dtd
@@ +42,5 @@
>    -->
>  <!ENTITY translation.options.attribution.beforeLogo "Translations by">
>  <!ENTITY translation.options.attribution.afterLogo "">
>  
> +<!ENTITY  drmContent.label             "DRM content">

I feel like this must run afoul of some regulation from the Department of Redundancy Department... A "DRM content" label in the "content" tabs of prefs for a "play DRM content" pref.

But I don't have a better suggestion. (Just "DRM" crossed my mind, but then we've got a weird / jargony 3-character header.)

Comment 5

[:Gijs (he/him)]

Inclusive of the redundancy inclusive*:

remote:   https://hg.mozilla.org/integration/fx-team/rev/1c1df7f43de0


* I'm sorry, I'm not as good at this as you are.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1c1df7f43de0
https://hg.mozilla.org/mozilla-central/rev/4d5442b5f446

Comment 7

[:Gijs (he/him)]

Uplifted in bug 1136165.

Comment 8

[mcdavis941 (sporadically reading bugmail)]

- (2015-03-05) (Fx37) https://hg.mozilla.org/releases/mozilla-beta/rev/4d6e9e4e5e87