Note: There are a few cases of duplicates in user autocompletion which are being worked on.

UITour: Highlights and panels remain visible when the browser is minimized

NEW
Unassigned

Status

()

Firefox
Tours
3 years ago
a year ago

People

(Reporter: agibson, Unassigned)

Tracking

37 Branch
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
I don't know if this is a dupe of 1125764, in which case please mark it as so. I only just noticed it today, so filing anyway just to be on the safe side :)

STR:

1.) Using the latest Nightly click Help -> Nightly Tour
2.) When the page loads, wait for the door-hanger to appear in the top corner
3.) Minimize the browser

Expected results:

The info panel and highlight should be hidden

Actual results:

The info panel and highlight remain visible

We used to work around this in the web page by hiding annotations on Page Visibility event changes.

Mozilla.UITour.hideHighlight();
Mozilla.UITour.hideInfo();

But this no longer appears to work since Bug 1110602 landed.
The workaround will work again after bug 1125764 but we should keep this open to fix it properly in-product. It was something I was fixing originally in a large patch to revamp teardown in bug 1110602 but I decided to split it into smaller pieces and do less to avoid breaking existing tours.

I'm not sure if there is a good way to detect minimizing (we get a visibilitychange but we can't distinguish between visibilitychange due to closing a tab vs. minimizing and we want to do different teardowns in those cases).

I think bug 1109868 could also help with this.
See Also: → bug 1109868
(Reporter)

Comment 2

3 years ago
I can confirm the workaround in bug 1125764 has fixed this again for now - will leave this open though as you suggest. Thanks, Matt!
I wonder if the recently fixed bug 1276120 helps with this on Windows.
You need to log in before you can comment on or make changes to this bug.