Closed
Bug 1127316
Opened 9 years ago
Closed 9 years ago
The try commit hook is missing commits with Try syntax in them
Categories
(Developer Services :: Mercurial: hg.mozilla.org, defect)
Developer Services
Mercurial: hg.mozilla.org
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: RyanVM, Assigned: gps)
References
Details
Attachments
(1 file)
2.52 KB,
patch
|
emorley
:
review+
|
Details | Diff | Splinter Review |
See the link below. Two csets in the push, both with Try syntax, went through without an issue. Presumably a regression from bug 1087328? https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=66f0f0b2bfd2
Flags: needinfo?(gps)
Comment 1•9 years ago
|
||
Need to use desc rather than firstline: https://hg.mozilla.org/hgcustom/version-control-tools/file/8e091ac4f8a1/hghooks/mozhghooks/commit-message.py#l47
Assignee | ||
Comment 3•9 years ago
|
||
When searching for Try syntax in commit messages, we should look at the entire commit message, not just the first line. The changed test fails before the corresponding hook change.
Attachment #8556710 -
Flags: review?(emorley)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → gps
Status: NEW → ASSIGNED
Updated•9 years ago
|
Attachment #8556710 -
Flags: review?(emorley) → review+
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/hgcustom/version-control-tools/rev/c89f6df7ae64
Assignee | ||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•