1127318 - Contacts with only a last name and a phone number in Gmail will be displayed as "{phoneNumber} {LastName}" while importing contacts from Gmail

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Johan Lorenzo [:jlorenzo]]

Attachment: Gmail screenshot

Prerequisites
Have a contact with only a last name and a phone number.

This issue is also reproducible if this contact has a title in Gmail. We'll take the example here of "Dr Who", "Dr" is the title and "Who" is the last name 

STR
1. Go to import from Gmail
2. Scroll down the list to the bottom.

Expected result
Like in Gmail, "Dr Who" should be displayed and should be indexed at "W". See "Gmail screenshot"

Actual result
You see the contact at the "#" index and your contact is called "[phone] Who". See "Contact import screenshot".

Comment 1

[Johan Lorenzo [:jlorenzo]]

Attachment: Contact import screenshot

Francisco, I have the feeling that this issue has been here for a while. Do you think it's worth it to ask for a branch check?

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

I'm sure it's not a regression, and has been there for a while.

Comment 3

[GitHub Autolander Bot]

Attachment: [PullReq] ythej:bug_1127318 to mozilla-b2g:master

Comment 4

[Vishnu Teja [:ythej]]

Attachment: Pull request for the bug 1127318

Hi Francisco,

I have added a mock contact file for testing.Please let me know if we need more mock contacts to test the condition.

Thank you !

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8559801 [details] [review]
Pull request for the bug 1127318

Canceling review of this patch, and doing it over the patch submitted by autolander.

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8559740 [details] [review]
[PullReq] ythej:bug_1127318 to mozilla-b2g:master

Great job!

Comment 7

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/27963

The pull request could not be applied to the integration branch. Please try again after current integration is complete.

Comment 8

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/27963

The pull request could not be applied to the integration branch. Please try again after current integration is complete.

Comment 9

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#Ei4kqXLzR22CJmeJ9_pYzA

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 10

[Vishnu Teja [:ythej]]

Hi Francisco,

The treeherder is green when I rebased on master but its says as comment 9.And it also says it can be merged  by who has right access to the repository !

Please see this : https://github.com/mozilla-b2g/gaia/pull/27963#issuecomment-73308142 .

Thank you.

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/ab84a7a670853acf86e6f5c25ba8254187c7586e

Comment 12

[Vishnu Teja [:ythej]]

Finally landed \o/

Comment 13

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on latest nightly build of Flame master by the STR in comment 0.

Actual results: When importing contacts from Gmail, it only displays the last name "Who" in gmail contact list, and "Who" is indexed at "#" because these contacts are ordered by first name.

See attachment: verified_Flame_master.png
Reproduce rate: 0/10


Device: Flame master (Verified)
Build ID               20150722010204
Gaia Revision          84c3bf622e211046d905803b34de5d331761f22d
Gaia Date              2015-07-21 16:28:35
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/8e5c888d0d89
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150722.042634
Firmware Date          Wed Jul 22 04:26:43 EDT 2015
Bootloader             L1TC000118D0
Firmware Version       v18D v3

Comment 14

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_master.png

Comment 15

[Shally Li（leave from Mozilla）]

Attachment: verify_Fail_Flame_master.png

Hi Vishnu,

    This bug has been verified as "Fail" on the latest nightly Flame master by the STR in comment 0. The "Who" contact (shows "Mr Who" in gmail) is indexed at "#" and not indexed at "W". 
    Could you help to check this problem? 

Thank you very much.

------------------------------------------------------------------------------
Actual results: When importing contacts from Gmail, it displays the last name "Who" in the list as expected, but the "Who" contact (shows "Mr Who" in gmail) is indexed at "#" and not indexed at "W".

See attachment: gmail_conatcts.PNG, verify_Fail_Flame_master.png and logcat.txt
Reproduce rate: 10/10


Device: Flame master (Fail)
Build ID               20150722010204
Gaia Revision          84c3bf622e211046d905803b34de5d331761f22d
Gaia Date              2015-07-21 16:28:35
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/8e5c888d0d89
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150722.042634
Firmware Date          Wed Jul 22 04:26:43 EDT 2015
Bootloader             L1TC000118D0
Firmware Version       v18D v3

Note： The contact app has some problem on the latest Flame master, so I use 20150722010204 to verify. 

Please let me know if necessary.

Comment 16

[Shally Li（leave from Mozilla）]

Attachment: gmail_conatcts.PNG

Comment 17

[Shally Li（leave from Mozilla）]

Attachment: logcat.txt

Comment 18

[Vishnu Teja [:ythej]]

Hey Shally,

I can't do it very soon as I am engaged in many other career works. When would you need to be fixed?

Comment 19

[Shally Li（leave from Mozilla）]

Hi Vishnu,

    I am not sure, but I think it can depend on your time, thanks.
    In addition, I will submit a following bug to track this bug.

Comment 20

[Shally Li（leave from Mozilla）]

The following up bug is bug 1187824.

Comment 21

[Vishnu Teja [:ythej]]

I will try to complete it by soon !

Thanks Shally :)