Closed Bug 112732 Opened 23 years ago Closed 23 years ago

'Check Spelling' dialog: Buttons do not have mnemonics (accesskey letter)

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

Product:
Core
Component:
DOM: UI Events & Focus Handling
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.0.1

People

(Reporter: olgam, Assigned: cmanske)

References

(Blocks 1 open bug)

Details

(Keywords: access, Whiteboard: [adt3 RTM] [fixed in branch])

Attachments

(1 file)

patch v1
8.67 KB, patch
neil
: review+
hewitt
: superreview+
cmanske
: approval+
Details | Diff | Splinter Review
Overview: Spelling dialog does not have mnemonics/access keys. Steps to reproduce: Enable Spell Check in Preferences. Create and send email including words to check. Actual Results: Spell Check dialog appears. No mnemonics. Expected Results: Keyboard access using mnemonics. Additional Information: I have a feeling that I saw this bug before. But I checked for spell, spelling, spell checking, mnemonics, access key - don't see it.
QA Contact: esther → olgam
jennifer, kin or beppe, is there a UI spec for access keys in the spellchecker dialog?
Keywords: access
Spec? What spec? :-P Seriously, I've never seen a spec for the spellchecker. Cc'ing cmanske, perhaps he knows of one used for 4.x, whose UI we started to mimic with a few changes here and there.
Mnemonics? You mean underlined character on a button so you can use keyboard to quickly trigger the button's actions? None of our buttons in any dialog in any application have that! I filed a bug on that issue long ago but can't seem to find it now.
You are right, a lot of work ahead! I am going to log related issues for dif. dialogs since multiple developers work on them and some dialogs/areas have diffferent priorities. If you find your bug - it would be great!
I would suggest not filing bugs for different dialogs until we have the XPFE/XUL support for the feature. I don't think Mac users care about it, but I know it's an important standard for Windows. Reassigning to that group
Assignee: sspitzer → hyatt
Component: Mail Window Front End → XP Toolkit/Widgets
Product: MailNews → Browser
QA Contact: olgam → jrgm
Summary: Spelling dialog does not have mnemonics → Buttons in dialogs do not have mnemonics (accesskey letter)
FYI, Mail already has a bunch of separate bugs for the dialogs that need mnemonics. And a few (very few) already have them implemented.
charley, the xul issue that blocks this is, i believe, bug 959 --which is being worked on. :)
Assignee: hyatt → cmanske
Component: XP Toolkit/Widgets → Editor: Composer
Depends on: Accesskey-XUL
QA Contact: jrgm → sujay
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.8
moving milestone.
Target Milestone: mozilla0.9.8 → mozilla0.9.9
Is this considered important for 1.0?
Keywords: nsbeta1
Target Milestone: mozilla0.9.9 → mozilla1.0
*** Bug 124416 has been marked as a duplicate of this bug. ***
Whiteboard: DEPENDS
Blocks: accesskey
Can this be re-summarized back to just the spelling dialog? The meta bug 129179 tracks implementing XUL access keys throughout the UI.
Why? Do you want a separate bug for each dialog?
Sorry, I thought Olga already had, based on comment 4.
I add in the Summary: 'Check Spelling' dialog. Aaron suggests to have all these bugs under 'Keyboard Navigation' component in the http://www.mozilla.org/projects/ui/accessibility/accesskey.html. So, I do it. I am going to review other existing bugs regarding mnemonics and make menta bug 129179 dependent on them.
Component: Editor: Composer → Keyboard Navigation
Summary: Buttons in dialogs do not have mnemonics (accesskey letter) → 'Check Spelling' dialog: Buttons do not have mnemonics (accesskey letter)
So I ask again: Aren't we suppose to fix this for all dialogs? Why did you change summary for just Spell Checking?
We have plans to fix this for all dialogs. But this bug is for Spell Checking. Somehow summary did not state it before. Other bugs point to different dialogs and show names of dialogs in their summaries.
removing myself from the cc list
Please update this bug with an [adt1] - [adt3] impact rating (or take it off the list if it doesn't even rate adt3.) Thanks!
simple to fix -- just need to add accesskey entries in DTD file
Whiteboard: DEPENDS → [adt3]DEPENDS
Attached patch patch v1 — — Splinter Review
There's some extra changes in EdSpellCheck.js and EdSpellCheck.xul to use separate "Close" and "Send" buttons. This makes it easier for I18N to figure out compatable accessKeys for each by keeping all strings in EditorSpellCheck.dtd.
Whiteboard: [adt3]DEPENDS → [adt3]DEPENDS[RTM][FIX IN HAND] need r=,sr=
Note that accessKeys for all other Composer UI is covered in bug 131672
Whiteboard: [adt3]DEPENDS[RTM][FIX IN HAND] need r=,sr= → [adt3]DEPENDS[RTM][FIX IN HAND] need sr=
Comment on attachment 80691 [details] [diff] [review] patch v1 sr=hewitt
Attachment #80691 - Flags: superreview+
Whiteboard: [adt3]DEPENDS[RTM][FIX IN HAND] need sr= → [adt3]DEPENDS[RTM][FIX IN HAND] reviewed
checked into trunk
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Whiteboard: [adt3]DEPENDS[RTM][FIX IN HAND] reviewed → [adt3 RTM]DEPENDS
Verified in 05-02 trunk build.
Status: RESOLVED → VERIFIED
I got confused to see on branch the dialog without mnemonics. I see, it is only on trunk - and verified on trunk.
Whiteboard: [adt3 RTM]DEPENDS → [adt3 RTM]
Keywords: nsbeta1 → nsbeta1+
adt1.0.0+ (on ADT's behalf) for approval to checkin to the 1.0 branch, pending Drivers approval. After, checking in, please add the fixed1.0 keyword.
Keywords: approval
Whiteboard: [adt3 RTM] → [adt3 RTM] [Needs a=]
adding the adt1.0.0+ mentioned in Jaime's comment.
Keywords: adt1.0.0+
changing to adt1.0.1+ for checkin to the 1.0 branch. Please get drivers approval before checking in.
Keywords: adt1.0.0+ → adt1.0.1+
Keywords: mozilla1.0.1
Target Milestone: mozilla1.0 → mozilla1.0.1
a=chofmann for 1.0.1
Comment on attachment 80691 [details] [diff] [review] patch v1 adding check for chofmann
Attachment #80691 - Flags: approval+
Keywords: mozilla1.0.1 → mozilla1.0.1+
Whiteboard: [adt3 RTM] [Needs a=] → [adt3 RTM] approved
checked into mozilla1.0.1 branch
Keywords: mozilla1.0.1+ → fixed1.0.1
verified in 6/4 branch build.
Happy to see it on branch!
Whiteboard: [adt3 RTM] approved → [adt3 RTM] [fixed in branch]
Keywords: fixed1.0.1 → verified1.0.1
Re: comment 5; Mac users don't care about the first letter being underlined, but they would like to be able to use command+accesskey in said dialogs (e.g., command+d for "Don't Save"). Is a separate bug needed for that?
Component: Keyboard: Navigation → User events and focus handling
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: