1127341 - Changing exposure set of an interface doesn't regenerate worker bindings that had that interface as an argument

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Bug 1121688 introduced a setup whereby the exposure set of an interface affects whether we generate overloads for worker-specific binding methods that take that interface type.

Unfortunately, the dep set of a method doesn't include the IDLInterfaces of its arguments; see the big comment in IDLWrapperType._getDependentObjects.

What this means is that if I have, in two different webidl files:

  interface X {};

and

  [Exposed=(Window,Worker)]
  interface Y {
    void foo(long arg);
    void foo(X arg);
  };

and Y has a worker-specific descriptor, we will generate a worker binding for Y without the "takes X" overload of "foo".  Then if X is modified to have [Exposed=(Window,Worker)] the binding for Y is not regenerated, since it has no explicit dependency on X.webidl.

Still thinking about ways we might be able to address this.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: If we make our codegen for a binding depend on the exposure set of an interface argument to one of the binding's methods, we need to adjust the dependency set of the binding accordingly, so we'll regenerate if the exposure set changes

Well, this is the brute-force approach...

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8556499 [details] [diff] [review]
If we make our codegen for a binding depend on the exposure set of an interface argument to one of the binding's methods, we need to adjust the dependency set of the binding accordingly, so we'll regenerate if the exposure set changes

Review of attachment 8556499 [details] [diff] [review]:
-----------------------------------------------------------------

Better than a clobber, definitely.

Comment 3

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/657c0635dfb9

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/657c0635dfb9