Closed
Bug 1127402
Opened 10 years ago
Closed 10 years ago
implement proxying relations
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
Tracking | Status | |
---|---|---|
firefox38 | --- | fixed |
People
(Reporter: tbsaunde, Assigned: tbsaunde)
References
Details
Attachments
(1 file)
11.92 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8556530 -
Flags: review?(dbolter)
Comment 2•10 years ago
|
||
Comment on attachment 8556530 [details] [diff] [review]
proxy RelationByType method
Review of attachment 8556530 [details] [diff] [review]:
-----------------------------------------------------------------
r=me. It took me a while to read this code and there was some 'hmm I assume this is right' that happened. Also, I think I have achieved my aspirations of being a human lint.
::: accessible/atk/AccessibleWrap.cpp
@@ +991,5 @@
> + atkRelation = atk_relation_new(wrappers.Elements(), wrappers.Length(),
> + atkType);
> + atk_relation_set_add(relation_set, atkRelation);
> + g_object_unref(atkRelation);
> + }
nit: indent above } two spaces.
::: accessible/ipc/DocAccessibleChild.cpp
@@ +174,5 @@
> + return false;
> +
> +#define RELATIONTYPE(gecko, s, a, m, i) AddRelation(acc, RelationType::gecko, aRelations);
> +
> +#include "RelationTypeMap.h"
nit: Why the spacer line?
::: accessible/ipc/PDocAccessible.ipdl
@@ +62,1 @@
> prio(high) sync TextSubstring(uint64_t aID, int32_t aStartOffset, int32_t
might as well indent the above two lines.
::: accessible/ipc/ProxyAccessible.cpp
@@ +105,5 @@
> + size_t targetCount = targetIDs.Length();
> + nsTArray<ProxyAccessible*> targets(targetCount);
> + for (size_t i = 0; i < targetCount; i++)
> + if (ProxyAccessible* proxy = mDoc->GetAccessible(targetIDs[i]))
> + targets.AppendElement(proxy);
the 'for' is indented 4 spaces too many, the 'if' in indented 2 spaces too many.
@@ +131,5 @@
> +
> + size_t targetCount = ipcRelations[i].Targets().Length();
> + nsTArray<ProxyAccessible*> targets(targetCount);
> + for (size_t j = 0; j < targetCount; j++)
> + if (ProxyAccessible* proxy = mDoc->GetAccessible(ipcRelations[i].Targets()[j]))
line above needs indent.
Attachment #8556530 -
Flags: review?(dbolter) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•