Closed Bug 1127430 Opened 5 years ago Closed 5 years ago

More style cleanups in nsWebBrowser


(Core Graveyard :: Embedding: APIs, defect)

Not set


(firefox38 fixed)

Tracking Status
firefox38 --- fixed


(Reporter: mccr8, Assigned: mccr8)



(4 files)

I can't take these three space indents any more.
You've managed to found one of the least maintained piece of code ;)
Only about 14-16 years old.

(But we do use nsWebBrowser for all the b2g/e10s stuff, since TabChild uses the embedding APIs)
Yeah, that's why I'm looking at it. ;)
Comment on attachment 8558732 [details] [diff] [review]
part 1 - Tuck more braces in nsWebBrowser.

>+   if (!mDocShell) {
>       if (aX)
>          *aX = mInitInfo->x;
>       if (aY)
>          *aY = mInitInfo->y;
>       if (aCX)
>          *aCX = mInitInfo->cx;
>       if (aCY)
>          *aCY = mInitInfo->cy;

{} also here please

>+      if (aX)
>+          *aX = bounds.x;
>+      if (aY)
>+          *aY = bounds.y;
>+      if (aCX)
>+          *aCX = bounds.width;
>+      if (aCY)
>+          *aCY = bounds.height;
and here
Attachment #8558732 - Flags: review?(bugs) → review+
Comment on attachment 8558733 [details] [diff] [review]
part 2 - Fix indentation in nsWebBrowser.

r+ based on the -w
Attachment #8558733 - Flags: review?(bugs) → review+
I put the extra braces you asked for in your review of part 1 into a new part 3, to avoid bit rotting the second patch.
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.