"Update Now" button redirects to "More Information" and not Update Now

RESOLVED FIXED in Firefox 48

Status

()

defect
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: salomj9+mozzila, Assigned: andy+bugzilla)

Tracking

35 Branch
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

(Whiteboard: [good first bug])

Attachments

(2 attachments)

Reporter

Description

4 years ago
Posted image UpdateNow.png
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20150122214805

Steps to reproduce:

Browser: 35.0.1
OS: Windows 7 SP1 x86-64

1) Go to "Add-Ons" Tab
2) Pick something like "Unity Player 4.3.4.31067"
3) Click the "Update Now" link


Actual results:

-Opens this link: https://blocklist.addons.mozilla.org/en-US/firefox/blocked/p556

-This reacts similar to if I click More Information on "Java Deployment Toolkit 7.0.650.20 10.65.2.20"

-I'd also like to note. I got this with Flash as well, but it redirected me to a page about why flash 11 was blocked and not even a page about why flash 16 was blocked.


Expected results:

I would expect it to update my browser or bring me to a page where I can update my browser.
User Agent 	Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:46.0) Gecko/20100101 Firefox/46.0
Build ID 	20151229030216

Tested on Windows 7 x64 with the Nightly 46.0a1 build. 
The add-ons with issues are blocked by Firefox for the safety of the user.
Please reopen the bug if you can offer any further information.
Thank you.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 3 years ago
Flags: needinfo?(salomj9+mozzila)
Resolution: --- → INVALID
The bug is very valid. I just filed a dup of this, bug 1264789
Status: RESOLVED → REOPENED
Ever confirmed: true
Resolution: INVALID → ---
Duplicate of this bug: 1264789
(I could misremember, but hasn't Mossop done some work on addon manager)
Flags: needinfo?(dtownsend)
The url we go to is just given to us in the blocklist from AMO.
Flags: needinfo?(dtownsend) → needinfo?(amckay)
Assignee

Comment 6

3 years ago
I don't think this is AMO. When about:addons renders the plugins page (this isn't about add-ons) it pings the blocklist at some point to see if the plugin is blocked. When it finds a blocked add-on it renders the list of plugins and assigns the value of extensions.blocklist.itemURL as the URL and applies the label of "Update Now".

At least I think that's what: 

https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/content/extensions.xml#1289-1306 

shows and the string comes from here:

https://dxr.mozilla.org/mozilla-central/source/toolkit/locales/en-US/chrome/mozapps/extensions/extensions.properties#40-41

I think in this case if its a plugin going to the url mentioned in bug 1264789 makes more sense, which is the value of plugins.update.url. And that should probably be a pretty simple fix to change. If there's no update available (I'm not sure how those are distinguished) I'm not sure what we should show.

I'm also not sure if that code is about just add-ons or plugins as well... perhaps a check on this.mAddon.isGMPlugin would help, but I'm just making stuff up at this point.
Flags: needinfo?(amckay)
Assignee

Updated

3 years ago
Assignee: nobody → amckay
Whiteboard: [good first bug]
Comment on attachment 8742080 [details]
MozReview Request: bug 1127476 point plugins to update check not blocklist page r?aswan

https://reviewboard.mozilla.org/r/46921/#review43717

::: toolkit/mozapps/extensions/content/extensions.xml:1296
(Diff revision 1)
>                this._error.textContent = gStrings.ext.formatStringFromName(
>                  "notification.vulnerableUpdatable",
>                  [this.mAddon.name], 1
>                );
>                this._errorLink.value = gStrings.ext.GetStringFromName("notification.vulnerableUpdatable.link");
> -              this._errorLink.href = this.mAddon.blocklistURL;
> +              this._errorLink.href = Services.urlFormatter.formatURLPref("plugins.update.url");

I had figured this would be something specific to the affected plugin but it doesn't look like we necessarily have a plugin-specific link available in the blocklist?
Attachment #8742080 - Flags: review?(aswan) → review+
Assignee

Comment 11

3 years ago
(In reply to Andrew Swan [:aswan] from comment #10)
> I had figured this would be something specific to the affected plugin but it
> doesn't look like we necessarily have a plugin-specific link available in
> the blocklist?

There isn't anything plugin specific in the blocklist to use, no :(
Flags: needinfo?(salomj9+mozzila)
Keywords: checkin-needed
Status: REOPENED → ASSIGNED
Component: Untriaged → Add-ons Manager
OS: Windows 7 → All
Product: Firefox → Toolkit
Hardware: x86_64 → All

Comment 13

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/05a9daa3368c
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.