1127480 - Pushlog should handle stripping

Status: RESOLVED FIXED

(Developer Services :: Mercurial: Pushlog, defect)

Description

[Gregory Szorc [:gps]]

Currently, if we run `hg strip` on a repository with a pushlog, the world explodes. Let's fix that by teaching the pushlog extension about repository destruction events.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: bz://1127480/gps

/r/3129 - pushlog: handle stripping (bug 1127480)

Pull down this commit:

hg pull review -r d1338ac70ec1d4d20ed8d86cf3b60654452cca37

Comment 2

[(not currently active) Ted Mielczarek]

https://reviewboard.mozilla.org/r/3129/#review2509

::: hgext/pushlog/__init__.py
(Diff revision 1)
> +                            'ORDER BY pushid, rev ASC')

As I said on IRC, iterating over every changeset in the repo seems terrible, but I don't have a better idea and I trust your judgement. Also having something that gives us a non-broken repo be slow seems better than having a broken repo.

Comment 3

[(not currently active) Ted Mielczarek]

https://reviewboard.mozilla.org/r/3129/#review2511

Ship It!

Comment 4

[Gregory Szorc [:gps]]

https://reviewboard.mozilla.org/r/3129/#review2513

> As I said on IRC, iterating over every changeset in the repo seems terrible, but I don't have a better idea and I trust your judgement. Also having something that gives us a non-broken repo be slow seems better than having a broken repo.

And as I said in IRC, this only takes a second or two, even on a large repository.

Comment 5

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/2a7a797f7f5a

Comment 6

[Gregory Szorc [:gps]]

I really wish MozReview granted r+ on the parent for single commit reviews...

Comment 7

[Gregory Szorc [:gps]]

This is deployed in production.

I even had to use it today. I stripped from version-control-tools a few days back and the repo wasn't mirroring due to a db constraint failure. Stripping the tip changeset to force a rebuild made everything happy again.

Comment 9

[Gregory Szorc [:gps]]

Attachment: MozReview Request: pushlog: handle stripping (bug 1127480)