1127515 - 'No results found' page with new UI refresh needs rework

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[krupa raj[:krupa]]

Attachment: prod

steps to reproduce:
1. Launch marketplace-dev app on your fxos device
2. search for a term which retruns no results


expected behavior:
"No results found" message is centered and there is a platform picker dropdown. (matching the previous design)

actual behavior:
"No results found" message is on the leftmost corner and does not look styled.

see screenshots.

Comment 1

[krupa raj[:krupa]]

Attachment: new ui

Comment 2

[Davor Spasovski [:spasovski]]

We're getting rid of the compat filter dropdown on no-results. Fixed typography. 

https://github.com/mozilla/fireplace/pull/988

Comment 3

[krupa raj[:krupa]]

(In reply to Davor Spasovski [:spasovski] from comment #2)
> We're getting rid of the compat filter dropdown on no-results. Fixed
> typography. 
> 
> https://github.com/mozilla/fireplace/pull/988

Why are we getting rid of the filter? Having a dropdown on that page would be useful in case the user has the option set to "My Device" they can then change it to "all apps" and see if there are any matching results.

This is fixed on desktop but it is still not styled on fxos device.

Comment 4

[Davor Spasovski [:spasovski]]

https://github.com/mozilla/fireplace/pull/996

Compat filter dropdown re-added.

Comment 5

[krupa raj[:krupa]]

'No results found' should be in bold.

See prod and dev: https://www.dropbox.com/s/abfgxfddtlmy96n/Screenshot%202015-02-05%2011.57.56.png?dl=0

Comment 6

[Davor Spasovski [:spasovski]]

https://github.com/mozilla/fireplace/pull/1005

Comment 7

[krupa raj[:krupa]]

verified fixed. Thanks!