1127523 - Allow functional tests to be run against any loop-server

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Mark Banner (:standard8)]

I whipped this patch together earlier, it allows the functional tests to be run against any server. All you need to do is change:

LOOP_SERVER=/path/to/server ./mach marionette-test browser/components/loop/test/functional/manifest.ini

to

LOOP_SERVER=http://localhost:5000 ./mach marionette-test browser/components/loop/test/functional/manifest.ini

The content server is according to the loop-server for now, although I think we could adjust it if we want to - I'll probably do that in a separate bug.

Comment 1

[Mark Banner (:standard8)]

Attachment: Allow functional tests to be run against any loop-server. NPOTB DONTBUILD

Simple patch, if it starts with http then use a different server.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8556685 [details] [diff] [review]
Allow functional tests to be run against any loop-server. NPOTB DONTBUILD

Review of attachment 8556685 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good; r=dmose.

Comment 3

[Mark Banner (:standard8)]

Attachment: Allow functional tests to be run against any loop-server. NPOTB DONTBUILD

and now for the patch that had the slightly less hacky version, but now also works.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8556725 [details] [diff] [review]
Allow functional tests to be run against any loop-server. NPOTB DONTBUILD

Review of attachment 8556725 [details] [diff] [review]:
-----------------------------------------------------------------

Looks even better. r=dmose

Comment 5

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/533c6020d5a9

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/533c6020d5a9