1127542 - libffi: NetBSD/powerpc support

Status: RESOLVED FIXED

(Core :: js-ctypes, defect)

Description

[Thomas Klausner]

Attachment: Patch handling NetBSD/powerpc like FreeBSD/OpenBSD.

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20150122214805

Steps to reproduce:

NetBSD/powerpc behaves like FreeBSD and OpenBSD. libffi's configure doesn't know about this yet. I've filed an upstream bug report with libffi to fix this, and it was accepted. Now I'd like to see this integrated into mozilla's copy of libffi.


Actual results:

The libffi commit is here:
https://github.com/atgreen/libffi/commit/06747d318761884e70dfa433a9548219fd779d7d

I'll attach the patch.

Comment 1

[Jason Orendorff [:jorendorff]]

Comment on attachment 8556709 [details] [diff] [review]
Patch handling NetBSD/powerpc like FreeBSD/OpenBSD.

Review of attachment 8556709 [details] [diff] [review]:
-----------------------------------------------------------------

Fine with me.

Comment 2

[Landry Breuil (:gaston)]

Attachment: same patch, also fixing configure.ac

Same patch formatted for hg with r= & bug # added, also took the liberty of tweaking configure.ac.

Comment 3

[Landry Breuil (:gaston)]

Since this touches a configure file, and last i did i got burnt, i'll let this to the sherrifs..

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8562980 [details] [diff] [review]
same patch, also fixing configure.ac

You don't need to set checkin? on top of checkin-needed. It just creates more busy work for those of us landing for you.

Also, you really should have included a diff in the libffi-patches dir as part of this patch, but since it's already taken upstream anyway, I guess it's not a huge deal.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d9df89f77ab1

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d9df89f77ab1