shipit-notifier should sleep before failing

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: rail, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 8556731 [details] [diff] [review]
shipit_notifier_sleep-tools.diff

Today I received an email from pulse.m.o that the queue has 2k+ messages.
I checked shipit-notifier and it was disabled in supervisor because it was failing too fast (there were some connection issues).

This should work around this problem.
Attachment #8556731 - Flags: review?(bhearsum)
Comment on attachment 8556731 [details] [diff] [review]
shipit_notifier_sleep-tools.diff

Review of attachment 8556731 [details] [diff] [review]:
-----------------------------------------------------------------

Should you adjust the supervisor config to not be so aggressive, too?
Attachment #8556731 - Flags: review?(bhearsum) → review+
(In reply to Ben Hearsum [:bhearsum] from comment #1)
> Comment on attachment 8556731 [details] [diff] [review]
> shipit_notifier_sleep-tools.diff
> 
> Review of attachment 8556731 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Should you adjust the supervisor config to not be so aggressive, too?

supervisor is not that flexible :(
Deployed
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.