1127609 - Debug log tab searches in wrong direction

Status: RESOLVED FIXED

(Instantbird Graveyard :: Other, defect)

Description

[aleth [:aleth]]

STR: Repeat search in a debug log tab using the keyboard will search upwards instead of downwards, which is confusing.

Probably due to having copied the findbar from a convbrowser.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Patch

This fixes the issue.
Let me know if the comment is good enough.

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

A bit of detail: the reversed searching happens because the find commands in instantbird.xul assume that all panels are conversations. The relevant keyboard shortcuts are Cmd(+Shift)+G.

Comment 3

[aleth [:aleth]]

Comment on attachment 8557649 [details] [diff] [review]
Patch

Review of attachment 8557649 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for taking care of this!

::: im/content/instantbird.xul
@@ +77,5 @@
> +                          return;
> +                        }
> +                        var panel = getTabBrowser().selectedPanel;
> +                        if (!panel) return;
> +                        if (panel.findbar) panel.findbar.onFindAgainCommand(false);"/>

I'm not sure, but would it be clearer to do something like

var findbar, isReversedDirection = false;
var conv = getTabBrowser.selectedConversation;
if (conv) {
  isReversedDirection = true;
  findbar = conv.findbar;
}
else {
  var panel = getTabbrowser.selectedPanel;
  if (!panel)
    return;
  findbar = panel.findbar;
}
findbar.onFindAgainCommand(isReversedDirection);

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Patch v2

Moves the code to a function that accepts one parameter to avoid duplication.

Comment 5

[aleth [:aleth]]

Comment on attachment 8564456 [details] [diff] [review]
Patch v2

Review of attachment 8564456 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 6

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/a4d860e127ed