1127678 - [SMS][Text Selection] Selection range is hard to change in SMS

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[howie [:howie]]

Description
Selection range is hard to change in SMS

Steps to Reproduce
1. Enter SMS, long press a message
2. Context menu appears, click select text
3. Move the caret try to change the selection range

Expected Results
Easily to move the caret and change the selection range

Actual Results
Context menu appears again, make it hard to change the selection range

Comment 1

[Julien Wajsberg [:julienw]]

Mmm maybe we should not display the context menu when we're in text selection mode. But I don't know if we can detect this state? Steve do you know more than me? :)

Or maybe the text selection subsystem should not send "contextmenu" events, but I'd prefer the first solution if we can know we're in selection mode.

Comment 2

[Steve Chung [:steveck]]

We can detect the state, but we will need to allow context menu when long press on other bubble. So maybe one more class for the bubble in selection mode is needed.

Comment 3

[Peter Bylenga [:PBylenga]]

this looks like a duplicate of bug 1127587

Comment 4

[GitHub Autolander Bot]

Attachment: [PullReq] steveck-chung:message-text-selection-polish to mozilla-b2g:master

Comment 5

[Steve Chung [:steveck]]

Attachment: Link to github

Hi Julien, it's small patch that disable the context menu while bubble is in select mode. I think this small chagne could improve experience properly.

Comment 6

[Julien Wajsberg [:julienw]]

I think it's bad enough to warrant a blocking status.

Comment 7

[Julien Wajsberg [:julienw]]

Comment on attachment 8559575 [details] [review]
Link to github

Answers on github.

We should avoid using the DOM as a state deposit :)

Comment 8

[Steve Chung [:steveck]]

Comment on attachment 8559575 [details] [review]
Link to github

Thanks for the suggestion, I agree that controlling event handler would be better.

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Triage meeting: not blocking as the user can still use the copy and paste.

Taking into account the size of the patch, please ask for approval 2.2 to get this in to the release.

Comment 10

[Julien Wajsberg [:julienw]]

Comment on attachment 8559575 [details] [review]
Link to github

r=me with some nits in the unit tests
thanks and don't forget to ask approval :)

Comment 11

[Steve Chung [:steveck]]

In master: https://github.com/mozilla-b2g/gaia/commit/2cbf5a7090353b97b41d1be92d5beae342504902

Comment 12

[Steve Chung [:steveck]]

Comment on attachment 8559575 [details] [review]
Link to github

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 1092437 (Text selection feature)
[User impact] if declined: Message context menu will be triggered easily while selection and brings bad use experience.
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: N/A

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/45501927c273268a0656bd6e523d28c160bdcbd1

Comment 14

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed on the latest Nightly Flame 3.0 and 2.2 builds.

Actual Results: The text selection Carats were easy to move where desired when selecting sms/mms text.

Environmental Variables:
Device: Flame 3.0 KK (319MB) (Full Flash)
BuildID: 20150305010212
Gaia: eff3321ab4e65da3f906688ebb55ddf1e93d9452
Gecko: 56492f7244a9
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Environmental Variables:
Device: Flame 2.2 KK (319MB) (Full Flash)
BuildID: 20150305002528
Gaia: 89af288bad6751248ff84504fa898206fee127fe
Gecko: 6d8d294aa8f3
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0