Closed Bug 1127701 Opened 5 years ago Closed 4 years ago

[Bluetooth] WARNING: NS_ENSURE_TRUE(value.isNumber()) failed: hfp/BluetoothHfpManager.cpp, line 688

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox41 fixed)

RESOLVED FIXED
FxOS-S4 (07Aug)
Tracking Status
firefox41 --- fixed

People

(Reporter: gyeh, Assigned: ben.tian)

Details

(Whiteboard: good first bug)

Attachments

(1 file, 1 obsolete file)

The warning is shown when booting up a real device.

Since the voice info hasn't ready yet, the return value is null and then the assertion failed.

https://dxr.mozilla.org/mozilla-central/source/dom/mobileconnection/MobileConnectionInfo.cpp#229
Whiteboard: good first bug
Steal this bug since I'm fixing bug 1127701 together.
Assignee: wiwang → btian
Attachment #8640281 - Flags: review?(joliu)
(In reply to Ben Tian [:btian] from comment #1)
> Steal this bug since I'm fixing bug 1127701 together.

Correction. Should be bug 1188394.
Comment on attachment 8640281 [details] [diff] [review]
Patch 1 (v1): Fix warning NS_ENSURE_TRUE(value.isNumber()) in HFP manager

Review of attachment 8640281 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks!
Attachment #8640281 - Flags: review?(joliu) → review+
(In reply to Ben Tian [:btian] from comment #4)
> Created attachment 8640361 [details] [diff] [review]
> [final] Patch 1: Fix warning NS_ENSURE_TRUE(value.isNumber()) failed, r=joliu
> 
> try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1409ca954ad7

The final patch adds fix for blueZ as well.
https://hg.mozilla.org/mozilla-central/rev/434bd4c4a8f2

Set flags as bug 1186394.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S4 (07Aug)
You need to log in before you can comment on or make changes to this bug.