If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Move tv_apps unit test from `_test` folder to `test`

RESOLVED INVALID

Status

Firefox OS
Gaia::TV
RESOLVED INVALID
3 years ago
3 years ago

People

(Reporter: chens, Assigned: chens)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Currently app tv_apps unit test files are sitting under tv_apps/{AppName}/_test, we should move them to tv_apps/{AppName}/test and enable them.
(Assignee)

Comment 1

3 years ago
Created attachment 8556995 [details] [review]
Pull request to master

Hi John,

I'm thinking moving these unit test files to `test` folder where it should be at, and enable tv's unit test on travis. Would you review this patch and give some feedback?
Assignee: nobody → chens
Status: NEW → ASSIGNED
Attachment #8556995 - Flags: review?(im)
Comment on attachment 8556995 [details] [review]
Pull request to master

The change looks good. But why does gaia try not run tv's unit test?? It should run all unit tests by default, I think.
Attachment #8556995 - Flags: review?(im) → review+
(Assignee)

Comment 3

3 years ago
We should come up a better way to run unit tests for tv apps, simply moving unit test files doesn't work.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.